Last modified: 2014-02-12 23:45:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55511, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53511 - [Beta] Clicking the hamburger icon sends user to Special:MobileMenu instead of just opening the menu on current page
[Beta] Clicking the hamburger icon sends user to Special:MobileMenu instead o...
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Unprioritized enhancement
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-29 00:56 UTC by Steven Walling
Modified: 2014-02-12 23:45 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
mobile Safari (49.07 KB, image/jpeg)
2013-08-29 00:56 UTC, Steven Walling
Details

Description Steven Walling 2013-08-29 00:56:07 UTC
Created attachment 13193 [details]
mobile Safari

I am intermittently getting this error in Beta, where the mobile site directs me to en.m.wikipedia.org/wiki/Special:MobileMenu#mw-mf-page-left when clicking the hamburger, instead of just opening the menu on current page. Maryana said she's seen this as well.
Comment 1 Ryan Kaldari 2013-09-03 21:18:30 UTC
Probably need to load the JS at the top of the page.
Comment 2 Jon 2013-09-05 16:41:16 UTC
Just to confirm Steven this is only beta or do you see this on various modes? Is this a new thing or has this always been the case?

There are various things that could be happening - the most likely as Ryan suggests is that the JavaScript hasn't yet run. Alas there is not much we can do about this aside from making the page load as fast as possible as the element needs to exist before it is binded to the navigation. Another is that there is a JavaScript error somewhere preventing it from loading and a third option is that there were some experiments with touch events which might not be triggering for some reason.

Marking as an enhancement - although this is annoying - this could be seen as a useful feature on slow connections. The other option would be to disable the button until JavaScript has loaded which I think is not such a good experience.

I personally think we should focus on making the page load as fast as possible which will also make this problem go away.
Comment 3 Steven Walling 2013-09-05 20:13:41 UTC
(In reply to comment #2)
> Just to confirm Steven this is only beta or do you see this on various modes?
> Is this a new thing or has this always been the case?
> 
> There are various things that could be happening - the most likely as Ryan
> suggests is that the JavaScript hasn't yet run. Alas there is not much we can
> do about this aside from making the page load as fast as possible as the
> element needs to exist before it is binded to the navigation. Another is that
> there is a JavaScript error somewhere preventing it from loading and a third
> option is that there were some experiments with touch events which might not
> be
> triggering for some reason.
> 
> Marking as an enhancement - although this is annoying - this could be seen
> as a
> useful feature on slow connections. The other option would be to disable the
> button until JavaScript has loaded which I think is not such a good
> experience.
> 
> I personally think we should focus on making the page load as fast as
> possible
> which will also make this problem go away.

Yes, this problem is likely the loading issue, because it only tends to happen on the first couple mobile pageviews. I have got the error only on Beta, but wouldn't be surprised if it showed up on stable too.
Comment 4 Gerrit Notification Bot 2013-09-07 00:20:33 UTC
Change 83207 had a related patch set uploaded by JGonera:
Make navigation.js load at the top

https://gerrit.wikimedia.org/r/83207
Comment 5 Gerrit Notification Bot 2013-09-09 21:02:51 UTC
Change 83561 had a related patch set uploaded by JGonera:
Introduce header-loaded event

https://gerrit.wikimedia.org/r/83561
Comment 6 Gerrit Notification Bot 2013-09-11 17:19:22 UTC
Change 83561 merged by jenkins-bot:
Introduce header-loaded event

https://gerrit.wikimedia.org/r/83561
Comment 7 Gerrit Notification Bot 2013-09-11 17:19:26 UTC
Change 83207 merged by jenkins-bot:
Make navigation.js load at the top

https://gerrit.wikimedia.org/r/83207
Comment 8 Jon 2013-09-11 17:19:35 UTC
Closing this since above patch is merged and this is the best we can do for the time being.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links