Last modified: 2014-04-16 16:11:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55512, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53512 - Support 'ondiscussionpage:' for LQT compatibility
Support 'ondiscussionpage:' for LQT compatibility
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
master
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-29 01:31 UTC by Alex Monk
Modified: 2014-04-16 16:11 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Alex Monk 2013-08-29 01:31:02 UTC
LQT's search uses the 'ondiscussionpage:' feature of Lucene, please implement it in Cirrus before Lucene is removed from WMF production so that LQT search does not break on Wikimedia wikis.
Comment 1 Nik Everett 2013-08-29 01:41:22 UTC
Will do.  Right next to ondiscussionpage: it looks like there is also inthread:.  Do you need that as well?

Do either of these make results that are useful in general search?  If so we should document them on http://en.wikipedia.org/wiki/Help:Searching .  That is where I found the features I have implemented.
Comment 2 Alex Monk 2013-08-29 02:12:03 UTC
(In reply to comment #1)
> Will do.  Right next to ondiscussionpage: it looks like there is also
> inthread:.  Do you need that as well?

alex@alex:/var/www/MediaWiki/Git/extensions/LiquidThreads (master)$ grep inthread * -R
alex@alex:/var/www/MediaWiki/Git/extensions/LiquidThreads (master)$ 

Probably not.

(In reply to comment #1)
> Do either of these make results that are useful in general search?  If so we
> should document them on http://en.wikipedia.org/wiki/Help:Searching .  That
> is
> where I found the features I have implemented.

On the English Wikipedia? No, that wiki does not have LiquidThreads.
Comment 3 Bawolff (Brian Wolff) 2013-08-29 02:29:37 UTC
Honestly its pretty useless on LQT. In my experiance the feature causes more problems then its worth due to the horrid UI. Some sites (Wikinews) use css to hide the search bar entirely due to spam resulting from this feature.
Comment 4 Nik Everett 2013-08-29 12:43:17 UTC
Whether or not the UI is good not having this would still break a feature in mediawiki.org.  I'm raising the priority back to normal as this blocks switching to the primary search backend for mediawiki.org, imho.
Comment 5 Alex Monk 2013-08-29 16:32:41 UTC
Well, I made Gerrit change #81601 so that LQT can survive the default changeover. But this is needed before Lucene can be removed from WMF production.
Comment 6 Jesús Martínez Novo (Ciencia Al Poder) 2013-08-29 16:39:33 UTC
(In reply to comment #3)
> Honestly its pretty useless on LQT. In my experiance the feature causes more
> problems then its worth due to the horrid UI. Some sites (Wikinews) use css
> to
> hide the search bar entirely due to spam resulting from this feature.

That's because of bug 37801
Comment 7 Nik Everett 2013-09-30 18:04:58 UTC
Lowering importance as we don't have plans to remove Lucene search from production for a while, even for wikis that are using CirrusSearch.
Comment 8 Nik Everett 2013-12-27 20:37:07 UTC
Does this still matter?  Are we still using this feature?
Comment 9 Alex Monk 2013-12-27 20:42:43 UTC
Yes. As far as I can remember it's still used when you submit an LQT search form.
Comment 10 Chad H. 2014-04-16 16:11:05 UTC
We're not going to implement this for Cirrus. Flow will have Cirrus integration. We should use Flow instead.

lsearchd will probably be running as secondary for awhile still so the search won't disappear immediately.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links