Last modified: 2013-09-05 05:37:47 UTC
After updating my local Flow extension to master I was getting Notice: Undefined index: rev_mod_state in /home/spage/projects/core/extensions/Flow/includes/Model/AbstractRevision.php on line 81 (repeat for Undefined indices rev_mod_user_id, rev_mod_user_text, rev_mod_timestamp) so I ran $ php ../../maintenance/update.php but that failed with PHP Fatal error: Class 'MWEchoDbFactory' not found in /home/spage/projects/core/extensions/Flow/maintenance/FlowInsertDefaultDefinitions.php on line 22 indeed, this is the only mention of the class in the Flow codebase. I hacked a factory invocation together that seems to work (gerrit update coming), but even after dropping the tables, when I rerun this I get the same "Undefined index" errors. flow_revision has the fields rev_mod_xxx so I'm not sure what the problem is.
Gerrit change #81628 replaces the MWEchoDbFactory call, but not the missing index failures.
Change 81628 had a related patch set uploaded by EBernhardson (WMF): fix missing MWEchoDbFactory::getDB() call https://gerrit.wikimedia.org/r/81628
i fixed up that patch, i must have been thinking about echo for some reason and used its dbfactory instead of flows, no clue why but fixed now :-) For the undefined indices, first try bouncing memcached. We cache a ton of stuff and to keep the pace of development up we havn't been worying about BC with existing cached data yet. Almost always when i get those errors its because the row came from old memcache values rather than mysql.
Change 81628 merged by EBernhardson (WMF): fix missing MWEchoDbFactory::getDB() call https://gerrit.wikimedia.org/r/81628
