Last modified: 2014-04-09 12:50:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55530, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53530 - Handle data values with value type "bad" gracefully
Handle data values with value type "bad" gracefully
Status: UNCONFIRMED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Wikidata bugs
: testme
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-29 10:12 UTC by Daniel Kinzler
Modified: 2014-04-09 12:50 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2013-08-29 10:12:48 UTC 
Due to a bug, the data value type 'bad' was sometimes recorded to the database when an UnDeserializableValue was encountered, instead of the originally intended data value type.

To fix this, we could look at the property type to determine and restore the appropriate data value type. 

A good place for this would be SnakObject::newFromArray, but that code (and the entire module!) doesn't have access to DataTypes or the PropertyDataTypeLookup. It's unclear to me how to best inject this, or whether it's better to try and implement this fallback somewhere else.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links