Last modified: 2013-08-31 16:56:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55543, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53543 - VisualEditor: Editing a <syntaxhighlight> block with the experimental generic editor leads to brokenness because the attributes get blanked
VisualEditor: Editing a <syntaxhighlight> block with the experimental generic...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-09-05
Assigned To: Ed Sanders
:
Depends on:
Blocks: 53614
  Show dependency tree / graph
 
Reported: 2013-08-29 17:16 UTC by Wojciech Różanek
Modified: 2013-08-31 16:56 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Wojciech Różanek 2013-08-29 17:16:25 UTC 
When I edit existing content in <source> tags, while editing it, error is shown about invalid language specified (lang=) and after saving it puts fragment of HTML code of this tag divs and entities into source of page and my code is broken.

https://www.mediawiki.org/w/index.php?title=VisualEditor:Test&oldid=773552
Comment 1 Gerrit Notification Bot 2013-08-30 23:29:22 UTC 
Change 82063 had a related patch set uploaded by Esanders:
Round trip alien extensions correctly when edited

https://gerrit.wikimedia.org/r/82063
Comment 2 Ed Sanders 2013-08-30 23:47:11 UTC 
Related bug 53614
Comment 3 Ed Sanders 2013-08-30 23:47:45 UTC 
This fix preserves attributes correctly. The above bug would allow you to edit them.
Comment 4 Gerrit Notification Bot 2013-08-31 00:44:04 UTC 
Change 82063 merged by jenkins-bot:
Round trip alien extensions correctly when edited

https://gerrit.wikimedia.org/r/82063
Comment 5 James Forrester 2013-08-31 14:22:33 UTC 
This is now fixed in master, and will be released to MediaWiki.org on Thursday 5 September. Sorry for the disruption.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links