Last modified: 2013-09-03 18:56:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55563, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53563 - Parser::parse() sent null title
Parser::parse() sent null title
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
RSS (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-29 20:58 UTC by Chad H.
Modified: 2013-09-03 18:56 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chad H. 2013-08-29 20:58:45 UTC
This extension doesn't behave nicely when parsing from the command line--that $wgTitle looks suspicious!

I'm currently getting the following stacktrace from CirrusSearch:

[29-Aug-2013 20:54:16] Catchable fatal error: Argument 2 passed to Parser::parse() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.22wmf15/extensions/RSS/RSSParser.php on line 297 and defined at /usr/local/apache/common-local/php
-1.22wmf15/includes/parser/Parser.php on line 351
Server: terbium
URL: http://[unknown-host]
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Parser.php(351): Parser::parse()
#1 /usr/local/apache/common-local/php-1.22wmf15/extensions/RSS/RSSParser.php(297): Parser->parse('{{RSSPost | tit...', NULL, Object(ParserOptions))
#2 /usr/local/apache/common-local/php-1.22wmf15/extensions/RSS/RSSParser.php(331): RSSParser->sandboxParse('{{RSSPost | tit...')
#3 /usr/local/apache/common-local/php-1.22wmf15/extensions/RSS/RSSHooks.php(96): RSSParser->renderFeed(Object(Parser), Object(PPFrame_DOM))
#4 [internal function]: RSSHooks::renderRss('http://blog.wik...', Array, Object(Parser), Object(PPFrame_DOM))
#5 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Parser.php(3992): call_user_func_array(Array, Array)
#6 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Preprocessor_DOM.php(1181): Parser->extensionSubstitution(Array, Object(PPFrame_DOM))
#7 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Parser.php(3121): PPFrame_DOM->expand(Object(PPNode_DOM), 0)
#8 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Parser.php(1201): Parser->replaceVariables('== Gallery ==?<...')
#9 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Parser.php(388): Parser->internalParse('== Gallery ==?<...')
#10 /usr/local/apache/common-local/php-1.22wmf15/includes/content/WikitextContent.php(300): Parser->parse('== Gallery ==?<...', Object(Title), Object(ParserOptions), true, true, 637440)
#11 /usr/local/apache/common-local/php-1.22wmf15/includes/WikiPage.php(3514): WikitextContent->getParserOutput(Object(Title), 637440, Object(ParserOptions))
#12 /usr/local/apache/common-local/php-1.22wmf15/includes/PoolCounter.php(222): PoolWorkArticleView->doWork()
#13 /usr/local/apache/common-local/php-1.22wmf15/includes/WikiPage.php(1126): PoolCounterWork->execute()
#14 /usr/local/apache/common-local/php-1.22wmf15/includes/Article.php(1811): WikiPage->getParserOutput(Object(ParserOptions), NULL)
#15 /usr/local/apache/common-local/php-1.22wmf15/extensions/CirrusSearch/CirrusSearchTextSanitizer.php(36): Article->getParserOutput()
#16 /usr/local/apache/common-local/php-1.22wmf15/extensions/CirrusSearch/CirrusSearch.body.php(53): CirrusSearchTextSanitizer::getSantizedTextFromTitle(Object(Title))
#17 /usr/local/apache/common-local/php-1.22wmf15/extensions/CirrusSearch/forceSearchIndex.php(215): CirrusSearch->getTextFromContent(Object(Title), Object(WikitextContent))
#18 /usr/local/apache/common-local/php-1.22wmf15/extensions/CirrusSearch/forceSearchIndex.php(89): ForceSearchIndex->findUpdates(Object(MWTimestamp), '111542', NULL)
#19 /usr/local/apache/common-local/php-1.22wmf15/maintenance/doMaintenance.php(115): ForceSearchIndex->execute()
#20 /usr/local/apache/common-local/php-1.22wmf15/extensions/CirrusSearch/forceSearchIndex.php(304): require_once('/usr/local/apac...')
#21 /usr/local/apache/common-local/multiversion/MWScript.php(97): require_once('/usr/local/apac...')
#22 {main}
Comment 1 T. Gries 2013-09-02 17:21:47 UTC
Pls. indicate the version of the Extension:RSS.. make sure to run latest(!) RSS and core.
Comment 2 Chad H. 2013-09-02 19:20:53 UTC
This is latest WMF branch, 1.22wmf15
Comment 3 T. Gries 2013-09-02 20:09:42 UTC
I mean, what version of the extension RSS do you use ?

Please checkout the latest version, see https://www.mediawiki.org/wiki/Extension:RSS

cd extensions
git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/RSS.git
Comment 4 Chad H. 2013-09-02 20:23:44 UTC
We are using the latest version of RSS (1.22, f2948e5) in 1.22wmf15.
Comment 5 T. Gries 2013-09-02 20:45:41 UTC
Did you mean 2.22, I suppose... based on the hash.

Can you join #wikimedia-dev please ?
Comment 6 T. Gries 2013-09-02 20:48:29 UTC
Chad, I need the RSS feed url. If you prefer, you can send it to by mail.
Comment 7 T. Gries 2013-09-02 21:08:58 UTC
just checked the latest RSS with latest Wikimedia (1.22alpha): works
Comment 8 Kevin Israel (PleaseStand) 2013-09-03 05:09:32 UTC
(In reply to comment #7)
> just checked the latest RSS with latest Wikimedia (1.22alpha): works

This is easy to reproduce. Just copy the code from
https://www.mediawiki.org/wiki/Extension:RSS#Example
and run it through the maintenance/parse.php script.
Comment 9 Gerrit Notification Bot 2013-09-03 05:10:11 UTC
Change 82366 had a related patch set uploaded by PleaseStand:
Fix parsing from CLI

https://gerrit.wikimedia.org/r/82366
Comment 10 Gerrit Notification Bot 2013-09-03 18:55:36 UTC
Change 82366 merged by Wikinaut:
Fix parsing from CLI; bumped to version 2.23

https://gerrit.wikimedia.org/r/82366
Comment 11 T. Gries 2013-09-03 18:56:38 UTC
thx for valuable help, commit. code review !

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links