Last modified: 2013-09-03 21:42:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55597, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53597 - GitHub replication: tags not getting pushed
GitHub replication: tags not getting pushed
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-30 16:28 UTC by Jeroen De Dauw
Modified: 2013-09-03 21:42 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jeroen De Dauw 2013-08-30 16:28:51 UTC
On 2013-08-26, 4 days ago, I created a tag for Diff [0]. While I'm writing this bug report, the tag has yet to appear on the GitHub mirror [1]. I made a commit after I first noticed the tag did not appear to see if replicating that would also sync the tags, which turned out not to be the case, as the commit made it onto GitHub, while the tag did not show up.

[0] tag "0.8" https://git.wikimedia.org/tags/mediawiki%2Fextensions%2FDiff.git
[1] https://github.com/wikimedia/mediawiki-extensions-Diff/releases
Comment 1 christian 2013-09-01 19:28:37 UTC
It seems no tags at all are replicated to GitHub, as neither core, nor
any of the repos that I checked show any tags on GitHub.

GitHub is the only replication target that comes with multiline 'push'
configs in the replication configuration. Could someone with shell
access to manganese check if the push configuration of puppet's
templates/gerrit/replication.config.erb gets correctly translated into
manganese's /var/lib/gerrit2/review_site/etc/replication.config?


(I double checked that gerrit's replication plugin can deal with 2
push lines.)
Comment 2 Chad H. 2013-09-01 19:54:49 UTC
Current replication.config: http://p.defau.lt/?9flQocqGKQosqBim6MKI8A

If I had to guess, I'd say the hacky line-wrapping I used before for multiple push entries aren't working since Antoine's fixes to better support lists here. Looks pretty fixable--just compare to the url lists.
Comment 3 Gerrit Notification Bot 2013-09-02 10:44:16 UTC
Change 82231 had a related patch set uploaded by QChris:
Specify push configurations for gerrit's replication in lists

https://gerrit.wikimedia.org/r/82231
Comment 4 Gerrit Notification Bot 2013-09-03 16:22:01 UTC
Change 82231 merged by Ottomata:
Specify push configurations for gerrit's replication in lists

https://gerrit.wikimedia.org/r/82231
Comment 5 christian 2013-09-03 21:42:12 UTC
Tags now get replicated again to github. The link
  https://github.com/wikimedia/mediawiki-extensions-Diff/releases
from the bug's description now shows the tags as well again.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links