Last modified: 2014-01-04 06:31:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55622, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53622 - Don't let autoconfirmed users see the result before voting
Don't let autoconfirmed users see the result before voting
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
AJAX Poll (Other open bugs)
master
All All
: Normal enhancement (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-31 10:21 UTC by zoglun
Modified: 2014-01-04 06:31 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description zoglun 2013-08-31 10:21:28 UTC
I just don't want autoconfirmed users see the result before voting.

Because the result could affect their decision.

$wgGroupPermissions['autoconfirmed']['ajaxpoll-vote'] = true;
$wgGroupPermissions['autoconfirmed']['ajaxpoll-view-results'] = true;
$wgGroupPermissions['autoconfirmed']['ajaxpoll-view-results-before-vote'] = false;
$wgGroupPermissions['*']['ajaxpoll-view-results'] = true;
$wgGroupPermissions['*']['ajaxpoll-view-results-before-vote'] = true;

I want, people who do not have right to vote able to see the result, but autoconfirmed user have to vote and then see the results. However, by setting like previous anonymous can't see the result at all.

MW 1.22wmf9
Comment 2 T. Gries 2013-09-01 11:12:09 UTC
Zoglun, I never coded something for the "autoconfirmed" group, which members are a subgroup of group "user", are they ?

I studied https://www.mediawiki.org/wiki/Manual:Autoconfirmed_users .

So, in my view - please correct me - what you propose is merely an enhancement - and clearly it is not a bug: you already marked this bugzilla as "enhancement".

Can you confirm ?

So I "simply" have to code your idea ?

Have you ever considered to code it by yourself and attach the output of "diff -bru old-version new-version" to this bugzilla? It is easy, and I can assist you in case you haven't done that before (let me know).
Comment 3 zoglun 2013-09-01 19:32:56 UTC
Well Gries, I really don't know the "autoconfirmed" does not contained in the code. The "enhancement" should be marked by other user in bugzilla.

I don't know how to code, but I may able to find someone who can add this function into AJAX poll. If I find such person, I will contact you.

Thank you!
Comment 4 T. Gries 2013-09-01 19:43:49 UTC
Zoglun, you misunderstood me. 

I will code this for you. No problem.

Please be patient.
Comment 5 zoglun 2013-09-01 21:44:38 UTC
Oh! Oh! Sorry for my poor English comprehend.
Comment 6 T. Gries 2013-09-03 22:06:28 UTC
Zoglun, I discovered the following problem with your idea:

1. You said "I want, people who do not have right to vote able to see the result," 

So, in that way you say: an anonymous person will see the results

2. When someone is autoconfirmed, you want to hide the results until the autoconfirmed person votes.

3. This does not make sense, because the autoconfirmed person can simply log-out, becomes then "anonymous" and can then see the results.

It does not make sense.

Please tell me, if my analysis is correct.
Comment 7 zoglun 2013-09-04 00:42:43 UTC
YES, Yes and yes. If an autoconfirmed user want to see the result he/she can log off and then see it.

I would like this function because most Asians (especially Japanese and Chinese) would like to follow "majority decision". A common sense among Japanese is to see what others choice. Therefore a little accidental higher vote number in the beginning could lead to final winning when the choice does not really matter their own life. Also, when choice not really important they wouldn't log off to see the result. That's too much trouble.

I know even after people have chosen, they can change the option. But, when people made a decision, they tend to persist on their own choice, Which would lead to more trustable result.


If you can't agree with my logic, I still would like you to add autoconfirmed users' right control in seniority order. It is acceptable to prohibit users' who have lower level see and vote. However, sometimes I really need autoconfirmed users vote to see how they think the wiki could be improved.
Comment 8 T. Gries 2013-09-04 01:21:48 UTC
Okay, I understand that you understand that it(the restriction not to be able to see results in your case) can be circumvented by clever users.

I will reconsider your wish, and try to implemented what you want in the next days.
Comment 9 T. Gries 2013-09-05 19:30:20 UTC
Zoglun, I prepared tables so get a better view what is needed. Please can I ask you to check the six relevant modes ? 

Perhaps I change the AJAXPoll code and code them as "six modes" rather than with "group permissions" to make the use of the extension easier.

Your mode is at the end.


+-------------------------------+-----------+------------------------+
|                               | anonymous |       user             |
| Standard                      |           +--------+---------------+
|                               |           | newbie | autoconfirmed |
+-------------------------------+-----------+--------+---------------+
| can see results before voting |     0     |    0   |        0      |
|-------------------------------+-----------+--------+---------------+
| can vote                      |     0     |    1   |        1      |
|-------------------------------+-----------+--------+---------------+
| can see results after voting  |     0     |    1   |        1      |
+-------------------------------+-----------+--------+---------------+

+-------------------------------+-----------+------------------------+
|                               | anonymous |       user             |
| Standard (poll closed)        |           +--------+---------------+
|                               |           | newbie | autoconfirmed |
+-------------------------------+-----------+--------+---------------+
| can see results before voting |     1     |    1   |        1      |
|-------------------------------+-----------+--------+---------------+
| can vote                      |     0     |    0   |        0      |
|-------------------------------+-----------+--------+---------------+
| can see results after voting  |     1     |    1   |        X      |
+-------------------------------+-----------+--------+---------------+

+-------------------------------+-----------+------------------------+
|                               | anonymous |       user             |
| Secret Ballot                 |           +--------+---------------+
|                               |           | newbie | autoconfirmed |
+-------------------------------+-----------+--------+---------------+
| can see results before voting |     0     |    0   |        0      |
|-------------------------------+-----------+--------+---------------+
| can vote                      |     0     |    1   |        1      |
|-------------------------------+-----------+--------+---------------+
| can see results after voting  |     0     |    0   |        0      |
+-------------------------------+-----------+--------+---------------+

+-------------------------------+-----------+------------------------+
|                               | anonymous |       user             |
| Open Ballot                   |           +--------+---------------+
|                               |           | newbie | autoconfirmed |
+-------------------------------+-----------+--------+---------------+
| can see results before voting |     0     |    0   |        0      |
|-------------------------------+-----------+--------+---------------+
| can vote                      |     1     |    1   |        1      |
|-------------------------------+-----------+--------+---------------+
| can see results after voting  |     1     |    1   |        1      |
+-------------------------------+-----------+--------+---------------+

+-------------------------------+-----------+------------------------+
|                               | anonymous |       user             |
| Fully Open Ballot             |           +--------+---------------+
|                               |           | newbie | autoconfirmed |
+-------------------------------+-----------+--------+---------------+
| can see results before voting |     1     |    1   |        1      |
|-------------------------------+-----------+--------+---------------+
| can vote                      |     1     |    1   |        1      |
|-------------------------------+-----------+--------+---------------+
| can see results after voting  |     1     |    1   |        X      |
+-------------------------------+-----------+--------+---------------+

+-------------------------------+-----------+------------------------+
|                               | anonymous |       user             |
| Zoglun's mode                 |           +--------+---------------+
|                               |           | newbie | autoconfirmed |
+-------------------------------+-----------+--------+---------------+
| can see results before voting |     1     |    1   |        0      |
|-------------------------------+-----------+--------+---------------+
| can vote                      |     0     |    1   |        1      |
|-------------------------------+-----------+--------+---------------+
| can see results after voting  |     1     |    1   |        1      |
+-------------------------------+-----------+--------+---------------+
Comment 10 zoglun 2013-09-06 00:53:04 UTC
I think "group permissions" may be better since unexpected request may comes out. Your "six modes" solution covered 99.9% situation. The (poll closed) mode is very useful, too!

If you decide to use the modes' solution, could you please change the last mode to "autoconfirmed user voting interference elimination" mode?

+-------------------------------+-----------+------------------------+
| autoconfirmed voting          | anonymous |       user             |
| interference elimination      |           +--------+---------------+
|                               |           | newbie | autoconfirmed |
+-------------------------------+-----------+--------+---------------+
| can see results before voting |     1     |    1   |        0      |
|-------------------------------+-----------+--------+---------------+
| can vote                      |     0     |    0   |        1      |
|-------------------------------+-----------+--------+---------------+
| can see results after voting  |     1     |    1   |        1      |
+-------------------------------+-----------+--------+---------------+
Comment 11 T. Gries 2013-09-06 06:49:14 UTC
(In reply to comment #10)
> I think "group permissions" may be better since unexpected request may comes
> out.
It appears technically very complicated to code the modes based on the permissions, but I will try and decide then, when I actually start coding.

> If you decide to use the modes' solution, could you please change the last
> mode
> to "autoconfirmed user voting interference elimination" mode?
Perhaps not this complicated name, but another one.
Comment 12 Liangent 2013-10-03 19:51:20 UTC
(In reply to comment #0)
> $wgGroupPermissions['autoconfirmed']['ajaxpoll-vote'] = true;
> $wgGroupPermissions['autoconfirmed']['ajaxpoll-view-results'] = true;
> $wgGroupPermissions['autoconfirmed']['ajaxpoll-view-results-before-vote'] =
> false;
> $wgGroupPermissions['*']['ajaxpoll-view-results'] = true;
> $wgGroupPermissions['*']['ajaxpoll-view-results-before-vote'] = true;

Looks like a misunderstanding of $wgGroupPermissions. Users get a specific permission bit once any of their user groups has the permission assigned. False values are actually ignored here (they're normally used to override default settings).

What you want might be $wgRevokePermissions. This is not well-documented on [[mw:Manual:User rights]] currently, and it should be.
Comment 13 Jackmcbarn 2014-01-04 04:11:59 UTC
Yes, the functionality you want is already present. Specifically, you want to use the following:
$wgRevokePermissions['autoconfirmed']['ajaxpoll-view-results-before-vote'] = true;
in addition to your other entries.

Since there doesn't appear to be an actual bug here, I'm closing this.
Comment 14 zoglun 2014-01-04 06:31:11 UTC
Thank you!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links