Last modified: 2014-10-20 13:51:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55662, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53662 - gerrit won't accept patches where only commit metadata differ
gerrit won't accept patches where only commit metadata differ
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-01 17:02 UTC by Bartosz Dziewoński
Modified: 2014-10-20 13:51 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2013-09-01 17:02:07 UTC
When I tried to submit a commit that was exactly the same as previous patchset, but with different commit date (git commit --date "Aug 17, 2013 8:21 PM"):

remote: (W) No changes between prior commit 3dfbedc and new commit 5522db6
To ssh://matmarex@gerrit.wikimedia.org:29418/mediawiki/extensions/Cite.git
 ! [remote rejected] HEAD -> refs/for/master (no changes made)
error: failed to push some refs to 'ssh://matmarex@gerrit.wikimedia.org:29418/mediawiki/extensions/Cite.git'
Comment 1 Chad H. 2013-09-01 17:09:29 UTC
Maybe you should make actual changes ;-)
Comment 2 Bartosz Dziewoński 2013-09-01 17:10:44 UTC
I made actual changes in previous commit and accidentally reset the date of somebody else's changeset.
Comment 3 Gerrit Notification Bot 2014-10-20 13:46:04 UTC
Change 167573 had a related patch set uploaded by QChris:
DO NOT MERGE. Test for commit bug\n\nThis is a test for bug 53662.\n

https://gerrit.wikimedia.org/r/167573
Comment 4 Gerrit Notification Bot 2014-10-20 13:48:03 UTC
Change 167573 abandoned by QChris:
DO NOT MERGE. Test for commit bug\n\nThis is a test for bug 53662.\n

Reason:
Test done

https://gerrit.wikimedia.org/r/167573
Comment 5 christian 2014-10-20 13:51:10 UTC
Whoops.
Misencoded newlines made hooks-bugzilla link the test commits.
(Resetting status of bug.)
Sorry for the noise.


But I could reproduce Bartosz' results.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links