Last modified: 2014-02-28 23:53:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55746, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53746 - VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rathe...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on: 52471
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-04 12:09 UTC by Chris McKenna
Modified: 2014-02-28 23:53 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McKenna 2013-09-04 12:09:26 UTC
en.wp user Professor Hog reports:
"If you try and use beta to edit a page, but you've forgotten to log in, so you log in directly off the beta page, once you have successfully logged in it takes you back to the edit source page instead of the beta page. Minor, but thought you may want to correct it? "
Comment 1 James Forrester 2013-09-04 16:00:07 UTC
I can't reproduce this - I get back to VisualEditor (as expected) - the login link is something like https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=Foobar&returntoquery=veaction%3Dedit

Can "Professor Hog" give any further details? What browser were they using? Can they reproduce? What about after a hard-refresh? Do they have any odd gadgets on the account into which they were logging-in?
Comment 2 Chris McKenna 2013-09-04 16:38:14 UTC
I'll ask for further clarification, but I've tested this in Firefox 23 on linux.

Clicking the link in the VE popup that notes you're not logged in reproduces this bug. (Note that this loads the login window in a new tab, I logged in there and was returned to the source editor in that window).

Dismissing that popup and then using the log in link at the top right of the page returned me to viewing the page not editing it in either editor.

The results are the same using my Thryduulf account which has a couple of gadgets, and my Awkward42 account which has none.
Comment 3 Chris McKenna 2013-09-04 16:50:36 UTC
To clarify the sequence I used to reproduce this was:
1. log out
2. load a page in VE. I tested with [[Symphony No. 8 (Mahler)]] and [[user:Thryduulf/sandbox]]
3. click to edit the page in VE
4. Click the "log in" link in the notice that pops up. 
This loads https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=User:Thryduulf/sandbox&returntoquery=action%3Dedit in a new tab.
5. In that new tab, log in as normal
Get returned to the source editor.

The edit notice shown is that in [[MediaWiki:Anoneditwarning]] where the link is hardcoded to the source editor (pre VE this would never have been an issue).

To me this suggests that either editor-relative urls are needed or we need different edit notices for the classic editor and VE (see bug 52741 for the latter)
Comment 4 James Forrester 2013-09-04 17:02:28 UTC
(In reply to comment #3)
> To clarify the sequence I used to reproduce this was:
> 1. log out
> 2. load a page in VE. I tested with [[Symphony No. 8 (Mahler)]] and
> [[user:Thryduulf/sandbox]]
> 3. click to edit the page in VE
> 4. Click the "log in" link in the notice that pops up. 
> This loads
> https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=User:
> Thryduulf/sandbox&returntoquery=action%3Dedit
> in a new tab.
> 5. In that new tab, log in as normal
> Get returned to the source editor.
> 
> The edit notice shown is that in [[MediaWiki:Anoneditwarning]] where the link
> is hardcoded to the source editor (pre VE this would never have been an
> issue).
> 
> To me this suggests that either editor-relative urls are needed or we need
> different edit notices for the classic editor and VE (see bug 52741 for the
> latter)

Oh, I see, I was clicking on "login" in the personal links bar - sorry. Re-titling so I don't get confused again. :-)
Comment 5 Chris McKenna 2013-09-04 17:21:06 UTC
Changing the depends on to bug 52471 (sorry, I typoed in comment 3)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links