Last modified: 2014-02-12 23:45:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55782, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53782 - Logged out users on mobile should not load JS for editing
Logged out users on mobile should not load JS for editing
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Unprioritized enhancement
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 48718
  Show dependency tree / graph
 
Reported: 2013-09-04 23:03 UTC by Ryan Kaldari
Modified: 2014-02-12 23:45 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Kaldari 2013-09-04 23:03:08 UTC 
It looks like we currently load all the JS for editing regardless of whether the user is logged in or not. We should probably put all the editing-related JS/CSS in its own RL module and only load it if the user is logged in.
Comment 1 Jon 2013-09-04 23:27:25 UTC 
this is a more specific version of https://bugzilla.wikimedia.org/show_bug.cgi?id=48718 maybe we should close that bug in favour of more actionable ones like this?
Comment 2 Ryan Kaldari 2013-09-05 20:39:25 UTC 
I just made this one a dependency.
Comment 3 Jon 2013-09-17 20:15:12 UTC 
https://gerrit.wikimedia.org/r/83943
Comment 4 Gerrit Notification Bot 2013-09-17 22:28:48 UTC 
Change 83943 had a related patch set uploaded by JGonera:
Load editor dynamically

https://gerrit.wikimedia.org/r/83943
Comment 5 Gerrit Notification Bot 2013-09-20 00:05:44 UTC 
Change 83943 merged by jenkins-bot:
Load editor dynamically

https://gerrit.wikimedia.org/r/83943
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links