Last modified: 2013-09-11 23:04:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55821, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53821 - Argument 1 passed to SpamBlacklist::filter() must be an array, object given
Argument 1 passed to SpamBlacklist::filter() must be an array, object given
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-05 19:16 UTC by Sam Reed (reedy)
Modified: 2013-09-11 23:04 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
aklapper: Backport_WMF+


Attachments

Description Sam Reed (reedy) 2013-09-05 19:16:54 UTC
[05-Sep-2013 21:15:32] Catchable fatal error: Argument 1 passed to SpamBlacklist::filter() must be an array, object given, called in /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/ArticleFeedbackv5.utils.php on line 360 and defined at /usr/local/apache/common-local/php-1.22wmf15/extensions/SpamBlacklist/SpamBlacklist_body.php on line 40
Server: mw1198
Method: POST
URL: http://fr.wikipedia.org/w/api.php
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf15/extensions/SpamBlacklist/SpamBlacklist_body.php(40): SpamBlacklist::filter()
#1 /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/ArticleFeedbackv5.utils.php(360): SpamBlacklist->filter(Object(Title), '', '')
#2 /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php(121): ArticleFeedbackv5Utils::validateSpamBlacklist('', 3252248)
#3 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(834): ApiArticleFeedbackv5->execute()
#4 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(380): ApiMain->executeAction()
#5 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(351): ApiMain->executeActionWithErrorHandling()
#6 /usr/local/apache/common-local/php-1.22wmf15/api.php(73): ApiMain->execute()
#7 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')
#8 {main}
[05-Sep-2013 21:15:46] Catchable fatal error: Argument 1 passed to SpamBlacklist::filter() must be an array, object given, called in /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/ArticleFeedbackv5.utils.php on line 360 and defined at /usr/local/apache/common-local/php-1.22wmf15/extensions/SpamBlacklist/SpamBlacklist_body.php on line 40
Server: mw1148
Method: POST
URL: http://fr.wikipedia.org/w/api.php
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf15/extensions/SpamBlacklist/SpamBlacklist_body.php(40): SpamBlacklist::filter()
#1 /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/ArticleFeedbackv5.utils.php(360): SpamBlacklist->filter(Object(Title), 'le d??veloppeme...', '')
#2 /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php(121): ArticleFeedbackv5Utils::validateSpamBlacklist('le d??veloppeme...', 569048)
#3 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(834): ApiArticleFeedbackv5->execute()
#4 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(380): ApiMain->executeAction()
#5 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(351): ApiMain->executeActionWithErrorHandling()
#6 /usr/local/apache/common-local/php-1.22wmf15/api.php(73): ApiMain->execute()
#7 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')
#8 {main}
Comment 1 Sam Reed (reedy) 2013-09-05 19:19:40 UTC
AFTv5:

		if ( $spam ) {
			$title = Title::newFromText( 'ArticleFeedbackv5_' . $pageId );
			$ret = $spam->filter( $title, $value, '' );
			if ( $ret !== false ) {
				return true;
			}
		}


SpamBlacklist:
	function filter( array $links, Title $title = null ) {
		$fname = 'wfSpamBlacklistFilter';


Based on that, $title should presumably be first...
Comment 2 Gerrit Notification Bot 2013-09-05 20:29:13 UTC
Change 82979 had a related patch set uploaded by Reedy:
Update AFTv5 to wmf/1.22wmf16 branch which includes live hack to fix fatal

https://gerrit.wikimedia.org/r/82979
Comment 3 Gerrit Notification Bot 2013-09-05 20:29:37 UTC
Change 82979 merged by Reedy:
Update AFTv5 to wmf/1.22wmf16 branch which includes live hack to fix fatal

https://gerrit.wikimedia.org/r/82979
Comment 4 Gerrit Notification Bot 2013-09-05 20:48:35 UTC
Change 83009 had a related patch set uploaded by Reedy:
Update AFTv5 to wmf/1.22wmf15 branch which includes live hack to fix fatal

https://gerrit.wikimedia.org/r/83009
Comment 5 Gerrit Notification Bot 2013-09-05 20:49:47 UTC
Change 83009 merged by Reedy:
Update AFTv5 to wmf/1.22wmf15 branch which includes live hack to fix fatal

https://gerrit.wikimedia.org/r/83009
Comment 6 Gerrit Notification Bot 2013-09-05 21:01:31 UTC
Change 83012 had a related patch set uploaded by Matthias Mullie:
(bug 53821) Update SpamBlacklist related code

https://gerrit.wikimedia.org/r/83012
Comment 7 Gerrit Notification Bot 2013-09-09 20:16:04 UTC
Change 83012 merged by jenkins-bot:
(bug 53821) Update SpamBlacklist related code

https://gerrit.wikimedia.org/r/83012

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links