Last modified: 2014-02-13 23:27:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55830, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53830 - incomplete translation triggers jquery.msg exception
incomplete translation triggers jquery.msg exception
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-05 23:22 UTC by spage
Modified: 2014-02-13 23:27 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-09-05 23:22:54 UTC
During the 2013-09-05 deploy, I visited http://test.wikipedia.org/wiki/Sandbox?debug=1&tour=firstedit after sync-common on mw1017 but before scap had started. So testwiki didn't have the rebuilt i18n cache with strings for the new firstedit tour.

In regular RL mode no message appeared and no tour; in debug mode this threw an error:

  Failed to load tour ext.guidedTour.tour.firstedit as module. err:
  Error: Parse error at position 0 in input: <guidedtour-tour-firstedit-edit-page-title>

...ow new Error( 'Parse error at position ' + pos.toString() + ' in input: ' + inpu...

, dependencies: ["ext.guidedTour.tour.firstedit"]

this is from mediawiki.jqueryMsg.js, I think wikiTextToAst(). This shouldn't happen in production and now scap has finished I can't reproduce; however, the usual behavior of MW i18n with unavailable messages is to dump them out as you'd see with ?uselang=qqx, rather than throw errors. So maybe there's something that can be made more robust in guidedTour or (more likely) in jqueryMsg.

Hmmm. I'm still getting the error on testwiki after scap completed, so maybe this is occurring due to something other than incomplete i18n. testwiki has Parsoid and VE extensions installed, but it's only showing me an [Edit] tab that leads to source editing.
Comment 1 Bartosz Dziewoński 2014-02-13 16:00:24 UTC
This is because GuidedTour is using internal jqueryMsg APIs instead of mw.message. The latter behaves as you described (dumping the error into parsed message text).
Comment 2 Matthew Flaschen 2014-02-13 23:03:41 UTC
If so, it should be fixed by https://gerrit.wikimedia.org/r/#/c/113279/ .

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links