Last modified: 2013-09-09 03:29:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55836, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53836 - Commit missing from mediawiki/exentions/MassMessage repo
Commit missing from mediawiki/exentions/MassMessage repo
Status: RESOLVED DUPLICATE of bug 53841
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: High major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 53841
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-06 05:17 UTC by Kunal Mehta (Legoktm)
Modified: 2013-09-09 03:29 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2013-09-06 05:17:56 UTC
https://gerrit.wikimedia.org/r/#/c/82796/ - sha1: 8587e2e4b4f90ca9cdba0f39e647b235921a5ae8

Missing on git.wm.o, gerrit, github:

https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FMassMessage.git

https://github.com/wikimedia/mediawiki-extensions-MassMessage/commits/master 

km-mpb:~ km$ git clone ssh://legoktm@gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage.git
Cloning into 'MassMessage'...
[snipped]
Checking connectivity... done
km-mpb:~ km$ cd MassMessage/
km-mpb:MassMessage km$ git log --oneline
85283ca Localisation updates from http://translatewiki.net.
b9ccd1c Autocomplete suggestions for spamlist input
3027dc6 Localisation updates from http://translatewiki.net.
8d106e1 Localisation updates from http://translatewiki.net.
[snipped]

Luckily this is a pretty minor change, so I can re-do it, but it really shouldn't have disappeared in the first place...
Comment 1 christian 2013-09-06 09:59:46 UTC
Eventhough the WebUI shows the change as having status 'Merged', the
change cannot be fetched directly:

  git fetch ssh://qchris@gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage refs/changes/96/82796/1
  fatal: Couldn't find remote ref refs/changes/96/82796/1
Comment 2 C. Scott Ananian 2013-09-06 16:11:59 UTC
This breakage seems to be a side-effect of the gerrit migration.  For me,

$ git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/VisualEditor
$ cd VisualEditor ; git log --oneline -1
feff1fb Merge "Improve welcome dialog support for large fonts"

versus

$ git clone https://git.wikimedia.org/git/mediawiki/extensions/VisualEditor.git
$ cd VisualEditor ; git log --oneline -1
47545a5 Remove no-insertion metadata corner case from `ve.dm.Transaction.pushReplace()`


Note that https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FVisualEditor shows the latter commit, but 'git review -s ; git log gerrit/master' shows the former.
Comment 3 Roan Kattouw 2013-09-06 18:09:02 UTC
(In reply to comment #2)
> This breakage seems to be a side-effect of the gerrit migration.  For me,
> 
> $ git clone
> https://gerrit.wikimedia.org/r/p/mediawiki/extensions/VisualEditor
> $ cd VisualEditor ; git log --oneline -1
> feff1fb Merge "Improve welcome dialog support for large fonts"
> 
I can't reproduce. I get
47545a5 Remove no-insertion metadata corner case from `ve.dm.Transaction.pushReplace()`.

as expected.
Comment 4 C. Scott Ananian 2013-09-06 19:09:44 UTC
Mea culpa -- my bug (in comment 2) was caused by an out-of-date entry for gerrit.wikimedia.org in my /etc/hosts file.  =(
Comment 5 C. Scott Ananian 2013-09-06 19:11:05 UTC
To the original reporter: can you confirm the IP address you are using for gerrit.wikimedia.org?  That would let us figure out if you have the same issue I was having, or a different one.
Comment 6 Kunal Mehta (Legoktm) 2013-09-06 20:08:56 UTC
I don't think my issue is the same since the commit is missing from both the web viewers on git.wm.o and github.

I'm not sure I've hardcoded an IP anywhere, I just use gerrit.wikimedia.org when cloning.
Comment 7 Chad H. 2013-09-06 20:28:25 UTC
(In reply to comment #6)
> I don't think my issue is the same since the commit is missing from both the
> web viewers on git.wm.o and github.
> 
> I'm not sure I've hardcoded an IP anywhere, I just use gerrit.wikimedia.org
> when cloning.

So what happened here was the change was merged without a merge commit. Will require some manual wrangling one way or the other to fix.
Comment 8 Kunal Mehta (Legoktm) 2013-09-06 21:56:24 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > I don't think my issue is the same since the commit is missing from both the
> > web viewers on git.wm.o and github.
> > 
> > I'm not sure I've hardcoded an IP anywhere, I just use gerrit.wikimedia.org
> > when cloning.
> 
> So what happened here was the change was merged without a merge commit. Will
> require some manual wrangling one way or the other to fix.

Maybe I'm misunderstanding, but the commit was merged just fine. It didn't need a merge commit since at the time, it was directly on top of the current HEAD. It was replicated to github fine, and I pulled locally using my gerrit remote. When the upgrade happened it vanished. At that point, it was missing from gerrit.wm.o, but it was still visible on github, until the l10n-bot updated the translations, off of the HEAD on gerrit, which was (force?) pushed to github and overrode the "fix typo" commit.
Comment 9 Ori Livneh 2013-09-09 03:29:03 UTC

*** This bug has been marked as a duplicate of bug 53841 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links