Last modified: 2014-09-19 22:01:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55840, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53840 - Allowed memory size of 183500800 bytes exhausted (tried to allocate 2018670161 bytes).
Allowed memory size of 183500800 bytes exhausted (tried to allocate 201867016...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-06 09:22 UTC by Rainer Rillke @commons.wikimedia
Modified: 2014-09-19 22:01 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rainer Rillke @commons.wikimedia 2013-09-06 09:22:20 UTC
PHP fatal error in /usr/local/apache/common-local/php-1.22wmf15/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg/File/Ogg/Media.php line 119: Allowed memory size of 183500800 bytes exhausted (tried to allocate 2018670161 bytes).

when uploading audio files (Ogg vorbis) at Wikimedia Commons. PLEASE ASAP ask the questions you need to debug/track down this issue. I can't provide the answer and must ask the reporter at https://commons.wikimedia.org/wiki/Commons:Upload_help#.22Unknown_error.22_when_uploading_audio_files_via_Upload_Wizard ( permalink: https://commons.wikimedia.org/w/index.php?title=Commons:Upload_help&oldid=103591481#.22Unknown_error.22_when_uploading_audio_files_via_Upload_Wizard )
Comment 1 Jan Gerber 2013-09-06 18:41:57 UTC
can you provide a link to the file you tried to upload.
Comment 2 Andre Klapper 2013-11-07 15:43:58 UTC
Rainer: can you provide a link to the file you tried to upload?
Comment 3 Rainer Rillke @commons.wikimedia 2013-11-07 22:10:26 UTC
This was reported by a user, not me. Andre asked him, if I recall correctly but they did not respond:

https://commons.wikimedia.org/wiki/Commons:Upload_help/Archive/2013/09#.22Unknown_error.22_when_uploading_audio_files_via_Upload_Wizard

https://commons.wikimedia.org/wiki/Commons:Help_desk/Archive/2013/09#Unable_to_upload_music_files_via_Upload_Wizard_and_Commons:_Upload

I've not seen any similar report recently.
Comment 4 Ryan Kaldari 2014-09-18 04:54:50 UTC
I get the same error any time I try to upload an OGG audio file via https://commons.wikimedia.org/wiki/Special:Upload:

PHP fatal error in /srv/mediawiki/php-1.24wmf21/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg/File/Ogg/Media.php line 119:
Allowed memory size of 268435456 bytes exhausted (tried to allocate 1802524276 bytes)

I tried files ranging in size from 13.2 MB to 6.1 MB. All failed with the same error.
Comment 5 Ryan Kaldari 2014-09-18 05:00:57 UTC
The error seems to happen in _decodeBareCommentsHeader(), which parses the comments header in the ogg file. This header contains a series of comments related to the audio encoded in the stream as well as a string to identify the encoding software. The encoding software that I used was MediaHuman Audio Converter, version 1.9.1.
Comment 6 Ryan Kaldari 2014-09-18 05:06:33 UTC
I think what's happening is that the function is choking when trying to parse the encoded COVERART comment, which is far larger than the other comments in the header.
Comment 7 Gerrit Notification Bot 2014-09-18 05:26:33 UTC
Change 161174 had a related patch set uploaded by Kaldari:
Protect against exceeding memory errors when parsing Ogg files

https://gerrit.wikimedia.org/r/161174
Comment 8 Ryan Kaldari 2014-09-18 05:45:13 UTC
For some reason, if I try to set any kind of size limit on the comments (even 100 MB), it causes several unit tests to fail. Anyone have any idea what's going on with those unit tests?
https://integration.wikimedia.org/ci/job/mwext-TimedMediaHandler-testextension/7/console
Comment 9 Ryan Kaldari 2014-09-18 06:24:10 UTC
In the meantime, I was able to upload the Ogg file by removing the cover art from the file.
Comment 10 Ryan Kaldari 2014-09-18 06:45:30 UTC
Got the unit tests passing with the fix. It's now skipping any comments that are longer than 10 KB, which should be more than enough for any of the information we're interested in.
Comment 11 Gerrit Notification Bot 2014-09-19 18:14:58 UTC
Change 161174 merged by jenkins-bot:
Protect against exceeding memory errors when parsing Ogg files

https://gerrit.wikimedia.org/r/161174
Comment 12 Ryan Kaldari 2014-09-19 22:01:10 UTC
Hopefully, this is fixed now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links