Last modified: 2013-09-25 14:16:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55884, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 53884 - Specifying an invalid section with action=edit doesn't throw a nosuchsection error


Summary:	Specifying an invalid section with action=edit doesn't throw a nosuchsection ...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	API (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	https://en.wikipedia.org/wiki/Special...
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-09-07 05:27 UTC by Kunal Mehta (Legoktm)
Modified:	2013-09-25 14:16 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2013-09-07 05:27:10 UTC

Was writing tests for testEditSection and noticed this...

Setting &section=300 on [[User:Legoktm]] (no sections at all) returns:

{
    "edit": {
        "result": "Success",
        "pageid": 14989378,
        "title": "User:Legoktm",
        "contentmodel": "wikitext",
        "nochange": ""
    }
}

It should have thrown an error of "nosuchsection".

Comment 1 Brad Jorsch 2013-09-10 20:20:06 UTC

I'm not entirely sure that this is a regression; if it is, it's not a recent one (probably dating back to when ContentHandler was introduced, although I haven't tested back that far). But yes, this should be fixed.

Comment 2 Brad Jorsch 2013-09-11 17:54:16 UTC

Looking at the code, I don't see any sign of a regression here.

Comment 3 Gerrit Notification Bot 2013-09-11 17:55:56 UTC

Change 83833 had a related patch set uploaded by Anomie:
API: Check for nosuchsection in all code paths

https://gerrit.wikimedia.org/r/83833

Comment 4 Gerrit Notification Bot 2013-09-24 22:46:04 UTC

Change 83833 merged by jenkins-bot:
API: Check for nosuchsection in all code paths

https://gerrit.wikimedia.org/r/83833

Comment 5 Brad Jorsch 2013-09-25 14:16:29 UTC

Change merged. It should be deployed to WMF wikis with 1.22wmf19, see https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap for the schedule.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links