Last modified: 2013-09-09 14:08:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55912, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 53912 - No fallback implemented for mb_strtolower (if mb extension is not enabled)


Summary:	No fallback implemented for mb_strtolower (if mb extension is not enabled)

Status:	NEW

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bryan Tong Minh 2013-09-08 15:24:23 UTC

SVG.php uses mb_strtolower, but this function is not defined in Fallback.php, causing unit tests to fail if the mb extension is not enabled.

Comment 1 Bartosz Dziewoński 2013-09-08 15:29:51 UTC

I think an alternate implementation exists in the form of Language#lc. It'd just have to be hooked up in appropriate places.

Comment 2 Bryan Tong Minh 2013-09-08 15:31:13 UTC

Or the implementation has to move to Fallback and Language could call mb_strtolower unconditionally