Last modified: 2014-03-25 22:46:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55914, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53914 - CodeEditor doesn't get along with MediaWiki:Gadget-wikEd.js
CodeEditor doesn't get along with MediaWiki:Gadget-wikEd.js
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeEditor (Other open bugs)
unspecified
All All
: High major with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-08 15:31 UTC by Technical 13
Modified: 2014-03-25 22:46 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Technical 13 2013-09-08 15:31:32 UTC
If WikEd is enabled when the .js page loads, there is no edit box.  Disabling WikEd brings up the edit box.  Disabling CodeEditor makes the box go away and it won't return without reloading the page.  Code editor should disable and remove WikEd before loading the page.
Comment 1 db [inactive,noenotif] 2013-09-08 17:27:33 UTC
That is a problem of wikEd and should be fixed on en.wp. WikEd can check for contentmodel/contentformat and not loaded or so.
Comment 2 Technical 13 2013-09-08 18:50:57 UTC
(In reply to comment #1)
> That is a problem of wikEd and should be fixed on en.wp. WikEd can check for
> contentmodel/contentformat and not loaded or so.

What does wikEd have to do with the second part of the problem? Disabling CodeEditor makes the box go away and it won't return without reloading the page.
Comment 3 Cacycle 2013-10-07 12:37:27 UTC
I have made wikEd compatible with CodeEditor in the current version (0.9.119c). wikEd will not load if the CodeEditor is turned on during page load. 

As long as the CodeEditor is turned off during page load, both can actually co-exist - just disable one before enabling the other.
Comment 4 Technical 13 2013-10-07 12:56:15 UTC
Will test and mark as WORKSFORME as is appropriate.  Just hoping I'll still be able to use wikEd's regex search and replace on .js and .css pages.
Comment 5 Cacycle 2013-10-07 13:13:17 UTC
wikEd and wikEd's syntax highlighting are turned off by default on .js pages because the syntax highlighting eats tabs. So be careful...
Comment 6 Derk-Jan Hartman 2014-01-10 11:19:08 UTC
I've update CodeEditor btw, preview here: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Module:Date&action=edit
Comment 7 Andre Klapper 2014-03-19 14:25:23 UTC
Which part of this report should be fixed in the CodeEditor codebase?
The loading order?
Comment 8 Cacycle 2014-03-19 16:10:06 UTC
For wikEd compatibility, everything would be fine without any changes. Unfortunately, there is Bug 62250...
Comment 9 Derk-Jan Hartman 2014-03-25 22:46:02 UTC
Closing, because taken care of, and remainder has separate ticket.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links