Last modified: 2013-10-02 18:57:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55917, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 53917 - VisualEditor: Hide "version false" in the help menu if it can't be shown


Summary:	VisualEditor: Hide "version false" in the help menu if it can't be shown

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	MediaWiki integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2013-09-19
Assigned To:	Ed Sanders

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-09-08 16:11 UTC by Helder
Modified:	2013-10-02 18:57 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2013-09-08 16:11:00 UTC

== Steps ==
1) Go to
https://www.mediawiki.org/wiki/BUG?veaction=edit&uselang=en
2) Click on "BETA"

== Actual result ==
There is the text "Version false" generated by the HTML:

<div>
 <span class="ve-init-mw-ViewPageTarget-version-label">Version</span> 
 <a class="ve-init-mw-ViewPageTarget-version-link"
    target="_blank"
    href="false">false</a> 
 <span class="ve-init-mw-ViewPageTarget-version-date"></span>
</div>

== Expected result ==
There should be some version number instead of the "false" text

Comment 1 John Mark Vandenberg 2013-10-02 01:46:44 UTC

I dont see 'false' on mw or en.wp.  I see 'beta'.

Is the originally reported problem fixed, or masked somehow.

I notice that version says '0.1.0', which is not useful as there have been many deploys of the code.  beta's should have build numbers or build dates for each release.

https://www.mediawiki.org/wiki/Special:Version

e.g. ULS is 'Version 2013-06-17'

Comment 2 Helder 2013-10-02 10:15:58 UTC

I don't see false anymore, but currently there is no element whose class contains "ve-init-mw-ViewPageTarget-version" either. Was this removed on purpose?

Comment 3 James Forrester 2013-10-02 18:57:56 UTC

Yes, this was exposed as part of bug 53050, but due to bug 53972 in how code is currently deployed to the WMF cluster, we can't actually make this available outside of Beta Labs (boo). Consequently this was fixed in Gerrit change #84334 two weeks ago before it hit "real" production wikis (non-MW.org).

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links