Last modified: 2013-12-02 20:16:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55927, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53927 - Templates and tables {{infobox ship begin}}
Templates and tables {{infobox ship begin}}
Status: RESOLVED DUPLICATE of bug 53139
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-08 20:56 UTC by Richard Morris
Modified: 2013-12-02 20:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Richard Morris 2013-09-08 20:56:48 UTC
This is going to give you a headache

{{Infobox ship begin}}
http://en.wikipedia.org/wiki/Template:Infobox_ship_begin
is used in 26840 pages. I provides styling for tables used to make infoboxes relating to ships. It is used like

{|{{Infobox ship begin}}
{{Infobox ship image
|Ship image=[[File:Whydah-model.jpg|300px]]
|Ship caption=The ''Whydah Gally'' (1716–1717)
}}
{{Infobox Ship Career
...
}}
|-
|Commanded by:
|Cap't. [[Lawrence Prince]]
...
|}

The template transcludes {{WPMILHIST Infobox style}} which provides CSS styling
class="infobox {{#if:{{{2|}}}|{{{2}}}}}" style="float: right; clear: right; width: 315px; border-spacing: 2px; text-align: left; font-size: 90%;"
So the table start tag and its styling are separate.

Unsurprisingly VE fails to edit pages with this template correctly. The following was reported at 
http://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=572065469

Open the article in the visual editor, e.g. by visiting https://en.wikipedia.org/wiki/Whydah_Gally?veaction=edit
Observe the article now leads with the out-of-place text 
 <nowiki>class="infobox " style="float: right; clear: right; width: 315px; border-spacing: 2px; text-align: left; font-size: 90%;"</nowiki>
try to click "save page" but note that it is not active
make a trivial change so that "save page" is active.  Click it
Click "review your changes", not that it says that
<nowiki>{{Italic title}}{|{{Infobox ship begin}}</nowiki>
was replaced with
<nowiki>{{Italic title}}{{Infobox ship begin}}
{|{{Infobox ship begin}}</nowiki>
Comment 1 ssastry 2013-09-11 00:57:33 UTC
Thanks for filing the report. We should have a fix for the edit corruption bug soon (it will be fixed as part of a patch that Arlo is working on). More later on the other parts of the bug, once we discuss how to handle this.
Comment 2 ssastry 2013-12-02 20:16:31 UTC

*** This bug has been marked as a duplicate of bug 53139 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links