Last modified: 2014-11-16 02:18:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55929, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53929 - "Reset your password" link should come after the password box
"Reset your password" link should come after the password box
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: roopak
https://en.wikipedia.org/wiki/Special...
: accessibility, design
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-08 21:26 UTC by Marcin Cieślak
Modified: 2014-11-16 02:18 UTC (History)
4 users (show)

See Also:
Web browser: Other
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of the userlogin page w/w3m (14.63 KB, image/png)
2013-09-08 21:28 UTC, Marcin Cieślak
Details
GUI screenshot with the link moved towards the bottom (66.92 KB, image/png)
2014-11-16 02:18 UTC, Marcin Cieślak
Details

Description Marcin Cieślak 2013-09-08 21:26:03 UTC
When using a text browser, the login page looks like here:

Jump to: navigation, search
Username [                    ]
Password Reset your password [                    ]
[ ] Keep me logged in (for up to 30 days)
[Log in]
Help with logging in

w3m (and some other text browsers) tabs over all links, images and fields, not obeying tabindex (for a reason - those need to be reachable somehow).

What happens now one has to tab over the "Reset your password" link once more to get to the password field. I suppose also screen reader user might be confused - "Reset your password" follows just the string "Password" in the HTML of the page:

<label for='wpPassword1'>
                        Password <a href="/wiki/Special:PasswordReset" title="Special:PasswordReset" class="mw-ui-flush-right">Reset your password</a>                        </label>
                        <input class="loginPassword" id="wpPassword1" tabindex="2" size="20" placeholder="Enter your password"
 type="password" name="wpPassword" />           </div>


Arguably, "Reset your password" does not belong to this <label> at all.
Even in the graphical browser, when reading LTR, one glances over "Password " and "Reset your password" labels, probably focusing more on "Enter your password" prompt in the field itself. Eyeballs shouldn't be bothered with
some not very often used link if the user is going to provide the password
right away.

I think those fields should be re-ordered, at least in HTML (and may be even
in the layout for the graphical browser).

I would suggest to move "Reset your password" before or after "Help logging in" - actually this could be on a single line with "Reset your password" probably right justified. Not sure what relative position of those should be vis-a-vis "Log in" button, but logically "reset your password" is some specific tool address on particular login problem; while the rest of the problems should be addressed in "Help logging in".

Please note that some sites (Google I think) call their forgot password "Problems logging in?" and therefore one link might cover all cases -
forgotten psssword, some more complex account recovery tool and some
general help. Additional "Help logging in" button is then unnecessary.

Most popular workflow should be "User name" -> "Password" -> "Log in" with all other buttons (remember 30 days, recover and help) moved out of the way, if possible.
Comment 1 Marcin Cieślak 2013-09-08 21:28:28 UTC
Created attachment 13258 [details]
Screenshot of the userlogin page w/w3m

A screenshot to illustrate the problem
Comment 2 roopak 2014-01-21 13:47:37 UTC
I would like to work on it.Can Saomeone assign it to me.
Comment 3 Tony Thomas 2014-01-21 13:48:37 UTC
Prepare the patch: 
http://www.mediawiki.org/wiki/Gerrit/Tutorial
Comment 4 Gerrit Notification Bot 2014-01-21 15:42:31 UTC
Change 108682 had a related patch set uploaded by Roopak:
Made the password box appear before "Reset your password"link

https://gerrit.wikimedia.org/r/108682
Comment 5 Andre Klapper 2014-05-26 15:03:18 UTC
16 lines patch by Roopak still awaiting more reviews in Gerrit... Anyone?
Comment 6 Sam Reed (reedy) 2014-11-02 17:01:12 UTC
(In reply to Andre Klapper from comment #5)
> 16 lines patch by Roopak still awaiting more reviews in Gerrit... Anyone?

I wonder if the Design team should really be looking at it. I suspect that's more important than the actual changed code
Comment 7 Marcin Cieślak 2014-11-16 02:18:31 UTC
Created attachment 17142 [details]
GUI screenshot with the link moved towards the bottom

In the patch set 10, I have moved the link towards the bottom of the screen, just before the "Help logging in" link.

I think it is better visible now and the interface seems to be more consistent, with the "help area" the bottom, after the action buttons.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links