Last modified: 2013-09-17 18:01:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55953, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53953 - Re-SUL on javascript login
Re-SUL on javascript login
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
master
All All
: High enhancement (vote)
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-09 17:43 UTC by Chris Steipp
Modified: 2013-09-17 18:01 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris Steipp 2013-09-09 17:43:06 UTC
To hopefully address the situation where users are reporting issues where they are logged in on some wikis, but not others, RobLa asked that we look into re-running the SUL logic after a user is logged in with the javascript ping.
Comment 1 Brad Jorsch 2013-09-09 18:31:30 UTC
Clarify, please? Is this asking to try to clear the localStorage already-checked-for-login-today "cookie" on say frwiki from the Special:CentralLogin/setCookies pixel loaded from enwiki?
Comment 2 Andre Klapper 2013-09-09 19:08:15 UTC
For the records: Also brought up in http://lists.wikimedia.org/pipermail/wikitech-l/2013-September/071718.html and https://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipedia&oldid=122384791#Erneut_zum_Unified_Login

Wondering if the patch for bug 53536 could influence the problem. Likely not.
Comment 3 Chris Steipp 2013-09-09 21:55:38 UTC
Andre, not really.

Brad, it was more running the CentralAuthDoEdgeLogin process again, if the user was logged in from the javascript ping. The localStorage might be contributing to the problem, but if we just re-run the login, then (in theory) it shouldn't matter too much.
Comment 4 Gerrit Notification Bot 2013-09-10 16:46:02 UTC
Change 83655 had a related patch set uploaded by Anomie:
Re-do edge login when JS login check succeeds

https://gerrit.wikimedia.org/r/83655
Comment 5 Gerrit Notification Bot 2013-09-16 18:22:07 UTC
Change 83655 merged by jenkins-bot:
Re-do edge login when JS login check succeeds

https://gerrit.wikimedia.org/r/83655

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links