Last modified: 2013-12-27 18:47:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56044, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 54044 - Title.php should consider ":" to be an invalid title


Summary:	Title.php should consider ":" to be an invalid title

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	1.23.0 release
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Duplicates:	53556 (view as bug list)
Depends on:	58793
Blocks:
	Show dependency tree / graph

Reported:	2013-09-11 22:45 UTC by Krinkle
Modified:	2013-12-27 18:47 UTC (History)
CC List:	5 users (show)

See Also:	51750
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2013-09-11 22:45:23 UTC

Title::newFromText(':') results in an apparently valid Title object that stringifies to "".

It seems to be caused by the following logic in Title#secureAndSplit:

> if ( $dbkey == '' && $this->mInterwiki == '' && $this->mNamespace != NS_MAIN ) {
> 	return false;
> }

The last check for namespace != NS_MAIN explicitly makes it so that 'Talk:' is considered invalid, but ':' is excluded for some reason.

Comment 1 Bartosz Dziewoński 2013-09-11 23:37:05 UTC

Related to bug 51750?

Comment 2 db [inactive,noenotif] 2013-09-12 16:26:22 UTC

*** Bug 53556 has been marked as a duplicate of this bug. ***

Comment 3 Gerrit Notification Bot 2013-12-06 17:13:17 UTC

Change 99674 had a related patch set uploaded by Umherirrender:
Make a single colon a invalid title in php and js

https://gerrit.wikimedia.org/r/99674

Comment 4 Gerrit Notification Bot 2013-12-06 23:47:42 UTC

Change 99674 merged by jenkins-bot:
Make a single colon an invalid title in php and js

https://gerrit.wikimedia.org/r/99674

Comment 5 Gerrit Notification Bot 2013-12-27 12:01:36 UTC

Change 104019 had a related patch set uploaded by Umherirrender:
Remove hints to fixed bug 54044

https://gerrit.wikimedia.org/r/104019

Comment 6 Gerrit Notification Bot 2013-12-27 15:41:29 UTC

Change 104019 merged by jenkins-bot:
Remove hints to fixed bug 54044

https://gerrit.wikimedia.org/r/104019

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links