Last modified: 2014-02-22 21:45:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56046, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54046 - Kraken unit-tests on Jenkins are failing
Kraken unit-tests on Jenkins are failing
Status: NEW
Product: Analytics
Classification: Unclassified
Refinery (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-11 23:35 UTC by Diederik van Liere
Modified: 2014-02-22 21:45 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Diederik van Liere 2013-09-11 23:35:52 UTC
Currently, 5 unit-tests for Kraken fail when running it on Jenkins:

1) org.wikimedia.analytics.kraken.pig.UserAgentClassifierTest.testIpad2: expected:<iPhone OS> but was:<iOS>
2) org.wikimedia.analytics.dclassjni.DclassWrapperTest.testDclassWrapper: Model as expected expected:<A63[80]> but was:<A63[66]>
3) org.wikimedia.analytics.dclassjni.DeviceClassificationTest.testDeviceClassification: Model as expected expected:<A63[80]> but was:<A63[66]>
4) org.wikimedia.analytics.kraken.pig.ComparePageviewDefinitionsTest.testMobilePageviewCount: expected:<(1[4,16],18)> but was:<(1[,1],18)>
5) org.wikimedia.analytics.kraken.pig.ComparePageviewDefinitionsTest.testDesktopPageviewCount: expected:<([1,5],2)> but was:<([0,0],2)>
Comment 1 Diederik van Liere 2013-09-12 00:06:28 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/analytics/cards/1146
Comment 2 Antoine "hashar" Musso (WMF) 2014-02-20 21:51:51 UTC
While talking with the analytics team, I noticed analytics/kraken does not have any Jenkins job being triggered when a change is submitted.  There is a manual job though http://integration.wikimedia.org/ci/job/Kraken/

I created a job in Jenkins using Jenkins Job Builder and added it in Zuul so it is now triggered.  The configuration is:

 https://gerrit.wikimedia.org/r/#/c/114622/2/analytics.yaml,unified

Aka it runs: maven clean package


I ran the job against a dummy commit ( https://gerrit.wikimedia.org/r/114531 ) and the jobs reports a lot of warnings and has some tests failures still.

Build page: http://integration.wikimedia.org/ci/job/analytics-kraken/6/

Tests results: http://integration.wikimedia.org/ci/job/analytics-kraken/6/testReport/

Console log: http://integration.wikimedia.org/ci/job/analytics-kraken/6/consoleFull
Comment 3 christian 2014-02-22 21:45:01 UTC
Fixing that is currently still not on our agenda :-(((

But since the errors and root causes are known, let me briefly chime in on
them (in case anybody else wants to fix the issues):

(In reply to Antoine "hashar" Musso from comment #2)
> http://integration.wikimedia.org/ci/job/analytics-kraken/6/consoleFull

-----Begin:log snippet-----
21:44:07 Failed tests:   testDclassWrapper(org.wikimedia.analytics.dclassjni.DclassWrapperTest): Model as expected expected:<A63[80]> but was:<A63[66]>
21:44:07   testDeviceClassification(org.wikimedia.analytics.dclassjni.DeviceClassificationTest): Model as expected expected:<A63[80]> but was:<A63[66]>
-----End:log snippet-----

Those two indicate that dclass is using a different wrong dtree file. We saw
those tests fail in the same way when trying to move from dtree v1.13 to v1.19.



-----Begin:log snippet-----
21:44:20 Tests in error: 
21:44:20   testDesktopPageviewCount(org.wikimedia.analytics.kraken.pig.ComparePageviewDefinitionsTest)
21:44:20   testMobilePageviewCount(org.wikimedia.analytics.kraken.pig.ComparePageviewDefinitionsTest)
-----End:log snippet-----

Those two indicate that the testdata_* CSVs are not in place (see kraken's
README.md)


Fixing the above two items should make the tests pass.
(Using current HEAD 
  35cfc89027b0220fe9ff42a626332e9d32813610
the tests pass for me.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links