Last modified: 2013-10-04 00:13:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56050, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 54050 - GitBlit markdown parser doesn't handle ` starting on a newline


Summary:	GitBlit markdown parser doesn't handle ` starting on a newline

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Git/Gerrit (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Unprioritized minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	https://git.wikimedia.org/blob/mediaw...
Whiteboard:
Keywords:	upstream

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-09-12 01:01 UTC by Kunal Mehta (Legoktm)
Modified:	2013-10-04 00:13 UTC (History)
CC List:	5 users (show)

See Also:	http://code.google.com/p/gitblit/issues/detail?id=308
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2013-09-12 01:01:56 UTC

My README.md file has certain lines that use the `` syntax for code examples. Looking at https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMassMessage.git/90df1f9c418d5481b1e9310ec7b93ebcecc4b621/README.md it seems that any line that starts with a ` is not parsed properly.

Compare to https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/README.md which renders correctly.

I'm guessing this is an upstream issue...

Comment 1 Chad H. 2013-09-12 01:46:52 UTC

(In reply to comment #0)
> I'm guessing this is an upstream issue...

Indeed. https://code.google.com/p/gitblit/issues/

Comment 2 Kunal Mehta (Legoktm) 2013-09-12 04:11:00 UTC

Thanks. Submitted as https://code.google.com/p/gitblit/issues/detail?id=308

Comment 3 Gerrit Notification Bot 2013-09-13 19:15:51 UTC

Change 84142 had a related patch set uploaded by saper:
Improve markdown and workaround bug 54050

https://gerrit.wikimedia.org/r/84142

Comment 4 Gerrit Notification Bot 2013-09-14 14:01:19 UTC

Change 84142 merged by jenkins-bot:
Improve markdown and workaround bug 54050

https://gerrit.wikimedia.org/r/84142

Comment 5 Marcin Cieślak 2013-10-04 00:13:12 UTC

Closing for now, it is debatable how upstream should behave (spec does not explain this, we aim at github behaviour). Solved by improving markdown markup.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links