Last modified: 2014-07-14 15:15:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56052, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54052 - tools.wmflabs.org inaccessible via labs instances
tools.wmflabs.org inaccessible via labs instances
Status: RESOLVED FIXED
Product: Wikimedia Labs
Classification: Unclassified
tools (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Tim Landscheidt
:
: 63787 64701 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-12 01:47 UTC by Betacommand
Modified: 2014-07-14 15:15 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Betacommand 2013-09-12 01:47:13 UTC
When a tool attempts to connect to any of the tools.wmflabs.org/* addresses you get timeout issues
Comment 1 Marc A. Pelletier 2013-09-16 16:54:06 UTC
That's an openstack limitation; its networking layer is actually unable to route from the inside to floating IPs.  You can, on the other hand, connect to the /internal/ IP of the proxy to the same effect: tools-webproxy
Comment 2 Betacommand 2013-09-16 17:24:38 UTC
That just seems like a hack, and adds an additional level of coding (detecting when functioning from within labs and from external) I know petan said he had a workaround to fix this.
Comment 3 Tim Landscheidt 2013-09-21 19:48:17 UTC
Can't we work around OpenStack's limitations with an entry in /etc/hosts?

In general, however, IMHO we should *strongly* discourage tools from accessing the webserver internally.  This not only wouldn't make use of the load-balancing grid, but put focused stress on the webserver, it also replaces the simplicity of an exec() call with the complexity of remote IPC, i. e. the network being available and not timing out, the webserver functioning as designed, the sub-job signalling its exit status properly back to the master, etc.
Comment 4 Betacommand 2013-09-21 20:01:24 UTC
That all depends on how its used, If say I wanted to use the output of someone elses tool, I have three options, some kind of internal only hack (using internal host names and what not) This only works from within labs, so if I wanted to share a function between something on labs and something on my local machine I would need to create a kludgey hack to see if it was being executed from within labs or not, and a fallback method for when its not being used on labs. OR I could just use one sane process thats not fucked up and not more complex than quantum mechanics and just use the tools.wmflabs.org url. One example is there is a tool on the toolserver that checks if an ip is part of tor or not. I incorporated the results of that tool into a more complex and more detailed report about an IP address. If that tool moves to labs I can no longer use it.
Comment 5 Marc A. Pelletier 2013-09-24 15:40:16 UTC
Whilst clearly ugly, stuffing the proxy address in /etc/hosts should provide a suitable workaround; at least until we move to a new networking layer for OpenStack.
Comment 6 Marc A. Pelletier 2013-09-24 15:43:55 UTC
"Fixed" (that is, tools.wmflabs.org now resolves to the web proxy's internal address).
Comment 7 Betacommand 2014-04-06 11:03:14 UTC
I would assume since the move to eqiad, it no longer functions correctly. Currently unable to access tools.wmflabs urls
Comment 8 Gerrit Notification Bot 2014-04-06 15:47:14 UTC
Change 123149 had a related patch set uploaded by Tim Landscheidt:
Tools: Alias tools.wmflabs.org to internal webproxy

https://gerrit.wikimedia.org/r/123149
Comment 9 Tim Landscheidt 2014-04-10 23:33:25 UTC
*** Bug 63787 has been marked as a duplicate of this bug. ***
Comment 10 DrTrigon 2014-04-23 21:53:23 UTC
To me and my bot this is a blocker - so please continue and merge.
Comment 11 Tim Landscheidt 2014-04-23 23:04:25 UTC
You can easily work around that by using tools-webproxy as Coren wrote in comment #1.
Comment 12 DrTrigon 2014-04-26 17:44:45 UTC
(In reply to Tim Landscheidt from comment #11)
> You can easily work around that by using tools-webproxy as Coren wrote in
> comment #1.

I don't understand how this should solve the issue? Could you please explain?

I assume - as Betacommand pointed out in comment #2 - this works only if pywikibot code would be changed? Right?
Comment 13 Merlijn van Deen (test) 2014-04-26 18:53:04 UTC
(In reply to DrTrigon from comment #12)
> I don't understand how this should solve the issue? Could you please explain?

Connect to tools-webproxy (i.e. using the internal IP) instead of tools.wmflabs.org (the external IP).

> I assume - as Betacommand pointed out in comment #2 - this works only if
> pywikibot code would be changed? Right?

How is this related to pywikibot?
Comment 14 DrTrigon 2014-04-26 20:28:21 UTC
subster.py takes user-defined urls and retrieves their content - how can I tell pywikibot to genrally use tools-webproxy instead of tools.wmflabs.org?

According to [1] it works if I run:

 export HTTP_PROXY=tools-webproxy

first, but then pages not on tools.wmflabs.org do not work anymore.

[1] http://ehc.ac/p/pywikipediabot/mailman/message/11020503/

How to solve?
Comment 15 Merlijn van Deen (test) 2014-04-26 20:37:02 UTC
tools-webproxy is not a proxy server you should use, but it's the internal address for tools.wmflabs.org. 

However, this does show there is a clear need for tools.wmflabs.org to be accessible *on that address* from the inside: tools such as weblinkchecker and subster take URLs that are used on a wiki, and do something with that URL.
Comment 16 metatron 2014-04-26 20:41:21 UTC
+1

If OpenStack has (DNS)-related limits here, maybe a hosts-entry can fix this issue.At least on Grid-/Exec-nodes and both Bastions.
Comment 17 DrTrigon 2014-04-28 17:39:34 UTC
So when will there be a fix (resp. merge of the proposed on above)?

As mentioned this a blocker for me and I cannot continue with testing, migrating from TS etc.
Comment 18 Steinsplitter 2014-05-01 09:02:19 UTC
*** Bug 64701 has been marked as a duplicate of this bug. ***
Comment 19 Gerrit Notification Bot 2014-06-04 13:49:12 UTC
Change 123149 abandoned by coren:
Tools: Alias tools.wmflabs.org to internal webproxy

Reason:
This is moot (and was not the right way to do it -- /etc/host is generated programmatically from the maintain-replicas script)

https://gerrit.wikimedia.org/r/123149
Comment 20 Marc A. Pelletier 2014-06-04 13:51:16 UTC
There is now a local alias on all instances to point the public name at the private IP (though not done with the proposed patch).
Comment 21 Tim Landscheidt 2014-06-04 14:36:02 UTC
(In reply to Gerrit Notification Bot from comment #19)
> Change 123149 abandoned by coren:
> Tools: Alias tools.wmflabs.org to internal webproxy

> Reason:
> This is moot (and was not the right way to do it -- /etc/host is generated
> programmatically from the maintain-replicas script)

> https://gerrit.wikimedia.org/r/123149

No, it doesn't looking at <http://git.wikimedia.org/blob/operations%2Fsoftware.git/7a1eac5e4e9a6bc16b0ec052acfe068c8db79472/maintain-replicas%2Fmaintain-replicas.pl>, and no other script in that repository creates an alias for tools.wmflabs.org either.  /etc/hosts is unmaintained at the moment.
Comment 22 Marc A. Pelletier 2014-06-04 14:40:24 UTC
Sorry, unmerged forked of it; bringing it in back to git is on my todo.  Same idea.  :-)
Comment 23 Tim Landscheidt 2014-06-04 15:25:47 UTC
(In reply to Marc A. Pelletier from comment #22)
> Sorry, unmerged forked of it; bringing it in back to git is on my todo. 
> Same idea.  :-)

Then let's leave this bug open until it's merged in case you get run over by a bus tomorrow :-).
Comment 24 Yuvi Panda 2014-06-04 15:27:16 UTC
What Tim said :)
Comment 25 Marc A. Pelletier 2014-06-04 21:22:35 UTC
The actual problem being fixed; bumping down.
Comment 26 Gerrit Notification Bot 2014-07-14 00:26:53 UTC
Change 146000 had a related patch set uploaded by Tim Landscheidt:
Tools: Add IP mapping for tools.wmflabs.org

https://gerrit.wikimedia.org/r/146000
Comment 27 Gerrit Notification Bot 2014-07-14 15:02:14 UTC
Change 146000 merged by coren:
Tools: Add IP mapping for tools.wmflabs.org

https://gerrit.wikimedia.org/r/146000
Comment 28 Yuvi Panda 2014-07-14 15:15:07 UTC
And finally :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links