Last modified: 2013-12-30 09:28:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56069, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54069 - [Regression] Placeholder for search input is black instead of gray
[Regression] Placeholder for search input is black instead of gray
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.22.0
All All
: Low trivial (vote)
: 1.22.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-12 09:08 UTC by Michael M.
Modified: 2013-12-30 09:28 UTC (History)
3 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael M. 2013-09-12 09:08:41 UTC
[1] added
 color: black
to
 div#simpleSearch input#searchInput,
which has a higher specifity than the selector with
 color: #999
for the placeholder in [2]ff.

[1] https://git.wikimedia.org/commitdiff/mediawiki%2Fcore.git/a9881e87d456305cc4ddc2fdf35cd346283f3072
[2] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/554a5d04433207c6386d8c54281ac4e58b220a47/skins%2Fvector%2Fscreen.css#L407
Comment 1 Bartosz Dziewoński 2013-09-12 10:58:54 UTC
Ugh, yes, my bad. Thanks for spotting. I5fe0543e fixes this among other issues.

Also, this only affects browsers without native placeholder support: very old Firefoxes and Operas and IE<10. http://caniuse.com/#feat=input-placeholder
Comment 2 Michael M. 2013-09-14 08:03:15 UTC
(In reply to comment #1)
> Also, this only affects browsers without native placeholder support

I (have to) use an old Firefox, but it is Firefox 10, which already has placeholder support, and the color changed to black there.
Comment 3 Gerrit Notification Bot 2013-10-18 22:12:40 UTC
Change 82100 had a related patch set uploaded by Bartosz Dziewoński:
Rewrite rendering of Vector simple search

https://gerrit.wikimedia.org/r/82100
Comment 4 Krinkle 2013-10-21 01:27:15 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Also, this only affects browsers without native placeholder support
> 
> I (have to) use an old Firefox, but it is Firefox 10, which already has
> placeholder support, and the color changed to black there.

Indeed, and that makes perfect sense.

Selector "div#simpleSearch input#searchInput" overrides "div#simpleSearch input.placeholder" (the emulated placeholder), but also  "div#simpleSearch input::-webkit-input-placeholder" and "div#simpleSearch input:-moz-placeholder". Both these selectors have the same specificity (element, id, element, class/pseudo-class)
Comment 5 Gerrit Notification Bot 2013-10-27 19:45:01 UTC
Change 92201 had a related patch set uploaded by Bartosz Dziewoński:
vector: Restore gray search input placeholder

https://gerrit.wikimedia.org/r/92201
Comment 6 Bartosz Dziewoński 2013-10-27 19:46:09 UTC
I submitted a separate patch for this since the big one probably isn't getting merged into 1.22. I'll make sure to backport it. Sorry about the mess.
Comment 7 Gerrit Notification Bot 2013-10-30 21:18:48 UTC
Change 92774 had a related patch set uploaded by Krinkle:
vector: Restore gray search input placeholder

https://gerrit.wikimedia.org/r/92774
Comment 8 Gerrit Notification Bot 2013-10-30 21:33:53 UTC
Change 92201 merged by jenkins-bot:
vector: Restore gray search input placeholder

https://gerrit.wikimedia.org/r/92201
Comment 9 Gerrit Notification Bot 2013-10-30 21:35:53 UTC
Change 92774 merged by jenkins-bot:
vector: Restore gray search input placeholder

https://gerrit.wikimedia.org/r/92774
Comment 10 Bartosz Dziewoński 2013-10-30 22:49:55 UTC
Fixed and backported. The fix should be included in next release candidate.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links