Last modified: 2013-09-19 18:04:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56083, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54083 - VisualEditor: <pre> tags have leading whitespace removed
VisualEditor: <pre> tags have leading whitespace removed
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-09-19
Assigned To: Ed Sanders
:
: 53775 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-12 17:46 UTC by Gabriel Wicke
Modified: 2013-09-19 18:04 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-09-12 17:46:31 UTC
Around the time when VE started to support editing of pres we started to get dirty diffs like this:

http://www.mediawiki.org/w/index.php?title=Parsoid&diff=779292&oldid=777387

This might either be a selser issue, or VE dirtying the DOM.
Comment 1 Roan Kattouw 2013-09-12 17:49:51 UTC
There's a check tag on the edit, so VE dirtied something somewhere. That may or may not explain the whole bug, but we should fix it.
Comment 2 Gerrit Notification Bot 2013-09-16 15:44:17 UTC
Change 84332 had a related patch set uploaded by Esanders:
Fix check for preformatted when stripping whitespace

https://gerrit.wikimedia.org/r/84332
Comment 3 Gerrit Notification Bot 2013-09-18 01:11:47 UTC
Change 84332 merged by jenkins-bot:
Fix check for preformatted when stripping whitespace

https://gerrit.wikimedia.org/r/84332
Comment 4 Gerrit Notification Bot 2013-09-18 23:01:10 UTC
Change 84896 had a related patch set uploaded by Catrope:
Fix check for preformatted when stripping whitespace

https://gerrit.wikimedia.org/r/84896
Comment 5 Gerrit Notification Bot 2013-09-18 23:03:15 UTC
Change 84896 merged by Catrope:
Fix check for preformatted when stripping whitespace

https://gerrit.wikimedia.org/r/84896
Comment 6 Roan Kattouw 2013-09-19 18:04:09 UTC
*** Bug 53775 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links