Last modified: 2014-05-16 20:11:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56091, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54091 - Search suggestions misplaced in Vector if there is window overflow (horizontal scrollbar)
Search suggestions misplaced in Vector if there is window overflow (horizonta...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.22.0
All All
: Low normal (vote)
: 1.24.0 release
Assigned To: Fomafix
https://de.wikipedia.org/wiki/Wikiped...
:
: 64613 65392 (view as bug list)
Depends on:
Blocks: 27411 44386
  Show dependency treegraph
 
Reported: 2013-09-13 08:03 UTC by Michael M.
Modified: 2014-05-16 20:11 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (18.13 KB, image/png)
2013-09-13 08:03 UTC, Michael M.
Details
Screecast of the broken search suggestions (479.93 KB, video/webm)
2013-12-15 13:19 UTC, Helder
Details

Description Michael M. 2013-09-13 08:03:50 UTC
Created attachment 13274 [details]
Screenshot

On [[de:Wikipedia:Fragen zur Wikipedia]] in Vector skin (and as far as I can see: only on this page) the search suggestions are misplaced and moved to the left (see screenshot). I have no idea what's going wrong, nor has anyone else yet.
Comment 1 Michael M. 2013-09-13 10:09:36 UTC
Experiments suggest that this has something to do with the CSS to move tabs on the right to a second line on small windows ([1]): When I start with a width where they are moved down the suggestions are positioned correctly, even if the tabs are collapsed afterwards to fit in one line again, and even if I increase the width of the window (without reloading).

Some users have this problem on other pages, too. On [2] there is an ongoing discussion (in German) about this bug.

[1] https://git.wikimedia.org/commitdiff/mediawiki%2Fcore.git/3d2abae2d493eee5ada56e8dad3a90b44d9aefd2
[2] https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#Suchvorschl.C3.A4ge_auf_dieser_Seite
Comment 2 Bartosz Dziewoński 2013-09-13 17:00:00 UTC
This is a side-effect of me fixing bug 20234. I don't see a way to get both bugs fixed simultaneously without somehow completely redoing how Vector tabs work :/
Comment 3 Michael M. 2013-09-14 08:01:04 UTC
Reading the comments on en's [1] and de's [2] village pumps I think most users prefer the old behaviour (overlapping tabs) anyway.

[1] [[Wikipedia:Village_pump_(technical)#Misplaced_tabs_when_zoomed_in]]
[2] [[de:Wikipedia:Fragen_zur_Wikipedia/Archiv/2013/Woche_34#Merkw.C3.BCrdige_Anzeige_bei_Netbook]]
Comment 4 Michael M. 2013-09-14 08:10:23 UTC
Now that I see your change to the title: No, the screenshot was taken without resizing the window (just a maximized window on my screen with innerWidth === 1280). On the contrary, resizing the window as described in comment 1 fixes the position of the suggestions (at least for me).
Comment 5 Bartosz Dziewoński 2013-09-15 16:22:48 UTC
Sorry, I must have misunderstood. Please fix the title so that it's correct (and a little more elaborate than the original one :) ), I don't want to mess something up again.
Comment 6 Helder 2013-12-15 13:19:00 UTC
Created attachment 14101 [details]
Screecast of the broken search suggestions
Comment 8 Gerrit Notification Bot 2014-04-29 19:02:33 UTC
Change 130425 had a related patch set uploaded by Gerrit Patch Uploader:
jquery.suggestions.js: Use body width instead of document width

https://gerrit.wikimedia.org/r/130425
Comment 9 Krinkle 2014-05-04 14:05:59 UTC
*** Bug 64613 has been marked as a duplicate of this bug. ***
Comment 10 Bartosz Dziewoński 2014-05-16 17:31:18 UTC
*** Bug 65392 has been marked as a duplicate of this bug. ***
Comment 11 Gerrit Notification Bot 2014-05-16 17:48:07 UTC
Change 130425 merged by jenkins-bot:
jquery.suggestions: Use body width instead of full document width

https://gerrit.wikimedia.org/r/130425

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links