Last modified: 2014-01-02 05:35:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56100, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54100 - Should not be possible to send thanks for oversighted edits
Should not be possible to send thanks for oversighted edits
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Thanks (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-13 14:27 UTC by Chris McKenna
Modified: 2014-01-02 05:35 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McKenna 2013-09-13 14:27:11 UTC
The (thanks) link still appears next to an edit that has been oversighted or otherwise suppressed. Clicking the link gives the confirmation as normal and clicking OK appears to send the thanks as normal (I'm waiting for confirmation of whether the thanks is received - I don't have access to oversight to test on one of my own edits).

Suppression of an edit should also suppress the ability to thank someone for that edit.

I spotted this bug at https://en.wikipedia.org/w/index.php?title=Wikipedia:Arbitration/Requests/Case/Manning_naming_dispute/Workshop&action=history where the edits from 00:26 to 02:37 on 13 September have been removed.
Comment 1 Chris McKenna 2013-09-13 15:14:29 UTC
The user concerned has replied saying that they did receive the thanks: 

"You did thank me, and it seemed to appear normally. The view edit link gave me this, which goes to the oversighted diff. [...] there did not seem to be anything overly broken about it."

The link given was https://en.wikipedia.org/w/index.php?title=Wikipedia:Arbitration/Requests/Case/Manning_naming_dispute/Workshop&oldid=572700018&diff=prev
Comment 2 Gerrit Notification Bot 2013-10-07 20:47:06 UTC
Change 88223 had a related patch set uploaded by Legoktm:
Only show Thanks links for public revisions

https://gerrit.wikimedia.org/r/88223
Comment 3 Gerrit Notification Bot 2013-10-30 17:47:05 UTC
Change 88223 merged by jenkins-bot:
Only allow Thanks for public revisions

https://gerrit.wikimedia.org/r/88223

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links