Last modified: 2014-09-02 20:11:48 UTC
Uploaded local files are not correctly auto-flagged, even when uploaded by an editor. Example (when somebody manually flags this, you can no longer reproduce, but there will always be some cases on [[de:Spezial:Neue_Dateien]]): [[de:Datei:Logo Langenfeld.svg]] was uploaded by an editor, and the history [1] correctly shows a flag "automatically checked". But on the file description page a note is shown: "Template/file changes in this version are pending review. The stable version was checked on 16 September 2013." It seems like the actual upload of the image (!= creation of image description page) unflagged the page, even thought it was uploaded by an editor. [1] https://de.wikipedia.org/w/index.php?title=Datei:Logo_Langenfeld.svg&action=history&uselang=en
This is reproducible for every new image uploaded to http://doomwiki.org; we are currently on MediaWiki 1.22.5 and the latest revision of FlaggedRevs. In order to clear the unreviewed status off of a new File: article, it is necessary to make a subsequent edit to its parent article, even if it is as trivial as adding whitespace, after the upload process has been completed. Otherwise, attempting to review it to clear the pending message presents you with a diff between two apparently identical revisions which both claim they are already checked. If you go through with approving it again while looking at this comparison without any changes, it fully acts like you approved it, but, you return to the File: article to see that it still claims it is unreviewed. We had a similar issue before upgrading, when we were on MW 1.16.2, so this is not an entirely new issue. It is however significantly more obnoxious than it was previously after upgrading.
Does this problem still appear?
I can this no longer reproduce for new files, but still for re-uploaded files. E.g. [[de:Datei:BZ - Verläufe von Rängen.png]] currently has the note "Template/file changes in this version are pending review.", while its history says that the latest version was flagged automatically. To reproduce use https://de.wikipedia.org/wiki/Spezial:Logbuch/upload?uselang=en and look for "uploaded a new version", there are several more examples.
We disabled transfer of reviewed status from files and template transclusions on DoomWiki.org due to a lack of resolution to this issue. I'll note doing so also broke our historical review data, to the point that I had to create and manually run a MySQL script to update the flaggedrevs table to make the timestamp fields self-consistent. I do not have any current plans to re-enable the feature due to problems like the above.
