Last modified: 2013-09-26 15:13:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56199, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54199 - Searches like "gro~s" cause Elasticsearch to barf back an error
Searches like "gro~s" cause Elasticsearch to barf back an error
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-17 01:40 UTC by Nik Everett
Modified: 2013-09-26 15:13 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nik Everett 2013-09-17 01:40:10 UTC
Searches like "gro~s" cause Elasticsearch to barf back an error:



      1 Warning:  Search backend error during full text search for 'gro~s'.  Error message is:  SearchPhaseExecutionException[Failed to execute phase [dfs], total failu
re; shardFailures {[nVH6MuLCT-Wprk3vavAs9Q][mediawikiwiki_general_red][0]: SearchParseException[[mediawikiwiki_general_red][0]: from[-1],size[-1]: Parse Failure [Failed
 to parse source [{"fields":["id","title","namespace","redirect"],"query":{"custom_score":{"script":"_score * log10(doc['links'].value + doc['redirect_links'].value + 2
)","query":{"query_string":{"query":"gro~s","fields":["title^20","heading^5","text","redirect.title^15"],"auto_generate_phrase_queries":true,"phrase_slop":3}}}},"highli
ght":{"pre_tags":["<span class=\"searchmatch\">"],"post_tags":["</span>"],"fields":{"title":{"number_of_fragments":0},"text":{"number_of_fragments":1},"redirect.title":
{"number_of_fragments":0},"heading":{"number_of_fragments":0}}},"suggest":{"text":"gro~s","phrase_title":{"phrase":{"field":"title.suggest","size":1,"max_errors":5,"con
fidence":2,"direct_generator":[{"f in /usr/local/apache/common-local/php-1.22wmf17/includes/debug/Debug.php on line 296
      1 Warning:  Search backend error during full text search for 'gro~s'.  Error message is:  SearchPhaseExecutionException[Failed to execute phase [dfs], total failu
re; shardFailures {[nVH6MuLCT-Wprk3vavAs9Q][mediawikiwiki_content_black][2]: SearchParseException[[mediawikiwiki_content_black][2]: from[-1],size[-1]: Parse Failure [Fa
iled to parse source [{"fields":["id","title","namespace","redirect"],"query":{"custom_score":{"script":"_score * log10(doc['links'].value + doc['redirect_links'].value
 + 2)","query":{"query_string":{"query":"gro~s","fields":["title^20","heading^5","text","redirect.title^15"],"auto_generate_phrase_queries":true,"phrase_slop":3}}}},"hi
ghlight":{"pre_tags":["<span class=\"searchmatch\">"],"post_tags":["</span>"],"fields":{"title":{"number_of_fragments":0},"text":{"number_of_fragments":1},"redirect.tit
le":{"number_of_fragments":0},"heading":{"number_of_fragments":0}}},"suggest":{"text":"gro~s","phrase_title":{"phrase":{"field":"title.suggest","size":1,"max_errors":5,
"confidence":2,"direct_generator": in /usr/local/apache/common-local/php-1.22wmf17/includes/debug/Debug.php on line 296
Comment 1 Gerrit Notification Bot 2013-09-17 20:38:35 UTC
Change 84630 had a related patch set uploaded by Manybubbles:
Escape queries that use ~ incorrectly.

https://gerrit.wikimedia.org/r/84630
Comment 2 Nik Everett 2013-09-17 20:45:59 UTC
I'll push some automated tests for review in a bit.
Comment 3 Nik Everett 2013-09-17 21:33:52 UTC
Automated tests: https://gerrit.wikimedia.org/r/#/c/84645/
Comment 4 Gerrit Notification Bot 2013-09-18 16:55:23 UTC
Change 84630 merged by jenkins-bot:
Escape queries that use ~ incorrectly.

https://gerrit.wikimedia.org/r/84630
Comment 5 Nik Everett 2013-09-18 17:45:25 UTC
All merged.
Comment 6 Nik Everett 2013-09-26 15:13:30 UTC
Verified on test2wiki.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links