Last modified: 2013-09-17 16:45:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56210, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54210 - ULS: Figure out the problems English Wiktionary is having and deal with it
ULS: Figure out the problems English Wiktionary is having and deal with it
Status: RESOLVED DUPLICATE of bug 53734
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-17 06:59 UTC by Krinkle
Modified: 2013-09-17 16:45 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-09-17 06:59:09 UTC
If there is a bug or ongoing discussion about this already, feel free to link it and close this bug. I couldn't find any however.

----------


On the infinite loop journey across site scripts, I had the unfortunate encounter with the following snippet of code[1]:


<<<

/* There have been literally a hundred thousand comments on the GP about how ULS breaks the fonts,
so I am copying code kindly provided by [[User:Kephir]] (just made a bit more suitable for children - 
who knows, they might be reading this too!).
If you were wondering why this is found at the very top, well it turns out there's some kind of
race condition in the ULS code so we want this to run as soon as possible.
Seriously, if I bothered to actually learn JavaScript and invest my time in it I could do this a
hundred times better than any of the MediaWiki developers. I swear. */
 
if ($(document.body).data('webfonts')) {
	// the damage has been done. undo it.
	$('[style], [lang], [class]').css('font-family', '');
}
 
delete mw.uls;
delete mw.webfonts;
delete $.fn.webfonts;
 
if (Object.defineProperty) {
	// and never come back!
	Object.defineProperty(mw, 'uls', { "configurable": false, "set": function () { throw new Error("error"); } });
	Object.defineProperty(mw, 'webfonts', { "configurable": false, "set": function () { throw new Error("error"); } });
	Object.defineProperty($.fn, 'webfonts', { "configurable": false, "set": function () { throw new Error("error"); } });
}

>>>

Now, I don't know whether they tried to contact the developers first (if not, that is arguably a small part of blame on them). However now that it has happened and we know about it, we need to do something about it.

I'm happy to help out in finding a solution (if needed), but as a start, I'd recommend someone in the language team do the following:

* Find, prioritise and resolve whatever issues are most prominent to the point that the community is willing to remove this hack.
* Or; if that requires significant development efforts (depends on how big these bugs are): immediately undeploy ULS from Wiktionary (enwiktionary and maybe others) and create a tracker bug for the blocking issues.


Undeployment may seem extreme, but the current situation is effectively so already. Either way, something needs to happen.


[1] https://en.wiktionary.org/w/index.php?title=MediaWiki:Common.js&oldid=22915160
Comment 1 Krinkle 2013-09-17 12:25:44 UTC
See also https://en.wiktionary.org/wiki/MediaWiki:Common.css (specifically the over 1000 lines long section setting font-family for different language content). Looks like something that the logic from WebFonts should be able to make prettier (e.g. worth it to use that through [lang=..] instead of their current css classes)
Comment 2 Niklas Laxström 2013-09-17 16:38:31 UTC
I'm marking this as duplicate of 53734. That's the only root cause for that change we are aware of.

*** This bug has been marked as a duplicate of bug 53734 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links