Last modified: 2014-05-07 21:01:05 UTC
Created attachment 13298 [details] Screenshot If you start ?tour=firstedit and then click veaction=edit, you get the wikitext-related Preview step unattached (see screenshot). This is a low priority issue, because users should only be getting the wikitext 'firstedit' tour if VE is not available. I am filing just in case the opposite situation might happen, i.e. users start a ?tour=vefirstedit, click Edit source, then get the VE tour step. If that's impossible, then this can be ignored for now.
Oh, I forgot the showConditionally. This is a trivial fix, and I'll do it tonight.
I was wrong about it being an easy fix. As far as I can tell, this never worked (wikitext tours not being loaded for VisualEditor). There are two different scenarios, which don't work for different reasons. However, it will work in the other direction (which is probably why I didn't catch this bug earlier): If it's a VE tour it will not show in the wikitext editor. I will fix this properly, but it looks like it may require some refactoring to do right.
Change 84735 had a related patch set uploaded by Mattflaschen: Declare tour as requiring wikitext, but it doesn't work yet. https://gerrit.wikimedia.org/r/84735
If you look at firstedit tour definition, you'll see that shouldSkip is set to call isEditing() Calling gt.isEditing() checks to see if you are either editing with wikitext or if the VisualEditor is loaded. However the tour step loads before ve is actually loaded. IMO: isEditing needs to return true if VisualEditor is loading or loaded. Locally this fixes the bug for me. I probably will make a patch for this.
