Last modified: 2013-09-18 23:01:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56257, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54257 - visible parsoid HTML in existing Flow content on toro
visible parsoid HTML in existing Flow content on toro
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-18 05:29 UTC by spage
Modified: 2013-09-18 23:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-09-18 05:29:52 UTC
I updated Flow, Parsoid, and VisualEditor on toro. Adding a new post worked fine and brought up VE (after a long delay during which the text area should probably be locked) and I could WYSIWYG. \o/

But existing summary and some posts on http://toro.wmflabs.org/wiki/Special:Flow/Sandbox_2 that have images and links in them show stuff like
  <a rel="mw:WikiLink" href=".//Subpage" data-parsoid="{"stx":"simple","a":{"href":".//Subpage"},"sa":{"href":"/Subpage"},"dsr":[89,101,2,2]}">

suggesting Flow is having problems figuring out Parsoid HTML content.

I had set $wgFlowUseParsoid=true, now I think obsolete. I tried setting $wgFlowContentFormat='html', didn't seem to change behavior.

Firebug reported some XHR errors, possibly from some VE API call, but now not.

If the issue is existing content doesn't render right, this is fine to mark WONTFIX. We haven't promised data compatibility yet.
Comment 1 spage 2013-09-18 05:57:27 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/185
Comment 2 Erik Bernhardson 2013-09-18 14:41:03 UTC
This is due to us previously not tracking what kind of content was stored in the field.  We now store a value of either 'html' or 'wikitext' in the content flags of the revision.  Not highly efficient, but the following query would fix the issue:


UPDATE flow_revision set rev_flags = CONCAT(rev_flags, ',html' ) WHERE rev_flags NOT LIKE '%html%' and rev_flags NOT LIKE '%wikitext%';

Untested, but should work.  Not sure if its worthwhile to build out the proper maintenance script to migrate.
Comment 3 spage 2013-09-18 23:01:29 UTC
(In reply to comment #2)
> This is due to us previously not tracking what kind of content was stored in
> the field.
Yup, flow_revision rev_flags had just 'utf-8'.

> UPDATE flow_revision set rev_flags = CONCAT(rev_flags, ',html' ) WHERE
> rev_flags NOT LIKE '%html%' and rev_flags NOT LIKE '%wikitext%';

It worked! (now Toro has other errors...)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links