Last modified: 2014-03-07 14:37:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56263, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54263 - EntityViewTest does not properly inject dependencies
EntityViewTest does not properly inject dependencies
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-18 08:50 UTC by Aude
Modified: 2014-03-07 14:37 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2013-09-18 08:50:17 UTC 
EntityViewTest has a newEntityView method that calls a static function EntityView::newForEntityContent() which pull in objects from the WikibaseRepo "registry" and from global state.

newEntityView is used in a bunch of test cases.
Comment 1 Lydia Pintscher 2014-02-26 11:43:58 UTC 
Let's put this as a fixme in the code. The whole thing needs to be rewritten anyway at which point this will no longer apply.
Comment 2 Adrian Lang 2014-03-07 14:37:36 UTC 
EntityView::newForEntityContent() does not exist anymore.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links