Last modified: 2013-09-25 20:50:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56292, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54292 - Autocreate not running on Special:CentralAutoLogin
Autocreate not running on Special:CentralAutoLogin
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-18 21:23 UTC by Chris Steipp
Modified: 2013-09-25 20:50 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris Steipp 2013-09-18 21:23:20 UTC
DGarry (WMF) was hitting a bug today where he logged into enwiki, and SUL logged him into most of the other projects. But, his account wasn't attached on commons, and so that autologin attempt failed, with an error in the header saying the user didn't have an attached account.

When he logged in directly on commons, the account was autocreated correctly.

We should be autocreating the accounts, like used to happen with the old AutoLogin.
Comment 1 Nemo 2013-09-19 16:46:28 UTC
(In reply to comment #0)
> his account wasn't attached
> on
> commons

Clarification to pre-SUL dinosaurs like me: it wasn't attached because it didn't exist at all locally. No local unattached accounts here, luckily.
[[Special:CentralAuth/DGarry (WMF)]]
Comment 2 Gerrit Notification Bot 2013-09-19 17:05:16 UTC
Change 84998 had a related patch set uploaded by Anomie:
Don't fail autologin for unattached accounts

https://gerrit.wikimedia.org/r/84998
Comment 3 Brad Jorsch 2013-09-19 17:05:57 UTC
(In reply to comment #0)
> We should be autocreating the accounts, like used to happen with the old
> AutoLogin.

Actually the old code didn't autocreate the accounts either, it just set the cookies regardless of whether a local account existed or was attached. And that works fine, because it's exactly the same situation as if you log in to enwiki but some unattached account has your name on dewiki.

And if we did autocreate the account we'd still have the bug where if an unattached user existed on say en.wiktionary then the SUL user wouldn't be auto-logged-in to any other wiktionaries either.

So what we really need to do is not care about the local account for the icons. But we do still need to care about the scripts, or we'll re-cause bug 51603.
Comment 4 Gerrit Notification Bot 2013-09-19 18:48:22 UTC
Change 84998 merged by jenkins-bot:
Don't fail autologin for unattached accounts

https://gerrit.wikimedia.org/r/84998
Comment 5 Chris Steipp 2013-09-25 20:50:25 UTC
Deployed

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links