Last modified: 2013-10-28 21:02:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56293, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 54293 - replies should be displayed most recent last


Summary:	replies should be displayed most recent last

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Flow (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	design

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-09-18 22:42 UTC by spage
Modified:	2013-10-28 21:02 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2013-09-18 22:42:26 UTC

In Jorm prototype and current design iterations, replies are shown in ascending date order.  But on toro, the most recent reply appears above previous replies, e.g. <http://toro.wmflabs.org/w/index.php?title=Special:Flow/Sandbox&topic[postId]=0503bd6a994b5d9616f9fa163e797af8&workflow=0503bd6a99435d9616f9fa163e797af8&action=view>

Comment 1 spage 2013-09-23 18:00:20 UTC

Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/189

Comment 2 Elliott Eggleston 2013-09-25 01:16:31 UTC

RootPostLoader::getMulti is explicitly sorting them newest first on line 74.  One could just change the comparison funtion to { 
	return $b->compareCreateTime( $a ); 
}

Comment 3 Erik Bernhardson 2013-09-30 20:09:02 UTC

That's right inline with my thinking,  the code was written up front to explicitly sort in one direction, we just need to flip it around.  This will be fixed sooner or later, just trying to focus on getting the card's in our current iteration closed out before taking on new bugs.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links