Last modified: 2013-12-04 13:43:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56320, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54320 - Add datatype to snaks in the external JSON
Add datatype to snaks in the external JSON
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks: 57212 57213 57231
  Show dependency tree / graph
 
Reported: 2013-09-19 12:00 UTC by denny vrandecic
Modified: 2013-12-04 13:43 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description denny vrandecic 2013-09-19 12:00:27 UTC 
The external JSON should contain a reference to the datatype of the snak for PropertyValue-Snaks.
Comment 1 Gerrit Notification Bot 2013-11-19 14:22:23 UTC 
Change 96258 had a related patch set uploaded by Daniel Kinzler:
Allow service injection into serializers.

https://gerrit.wikimedia.org/r/96258
Comment 2 Daniel Kinzler 2013-11-19 14:25:04 UTC 
Patch Ib2137ad adds support for the datatype field to SnakSerializer, which should be sufficient to consider this fixed. That however doesn't cause the datatype to show up in all JSON output, since the necessary lookup service isn't yet injected everywhere. For the specific use cases, I filed:

* bug 57212
* bug 57213
* bug 57231
Comment 3 Gerrit Notification Bot 2013-11-28 16:00:20 UTC 
Change 96258 merged by jenkins-bot:
(bug 54320) Include datatype in snak serialization.

https://gerrit.wikimedia.org/r/96258
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links