Last modified: 2014-03-19 11:15:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56324, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54324 - sequence in Lua should start with 1 but starts with 0
sequence in Lua should start with 1 but starts with 0
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-19 14:35 UTC by Lydia Pintscher
Modified: 2014-03-19 11:15 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lydia Pintscher 2013-09-19 14:35:55 UTC
Quoting from https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#.270.27_key_in_Lua_tables

"The most standard Lua tables are "sequence" where the key are natural numbers starting from 1, but Wikibase tables seem to have a key "0". It is a bit annoying. According to the documentation, "Many Lua functions operate only on sequences, and ignore non-positive-integer keys." For instance, the number of claims for a property, as given by #entity.claims.pXX is one less than expected. --Zolo (talk) 09:49, 19 September 2013 (UTC)"
Comment 1 Gerrit Notification Bot 2013-11-12 15:35:46 UTC
Change 94909 had a related patch set uploaded by Jens Ohlig:
(bug 54324) sequence in Lua should start with 1

https://gerrit.wikimedia.org/r/94909
Comment 2 Gerrit Notification Bot 2013-11-18 14:13:25 UTC
Change 94909 abandoned by Jens Ohlig:
(bug 54324) sequence in Lua should start with 1 Patch set 2: Reformatted Patch set 3: Oops, I meant to reformat it like this. Patch set 4: ...

https://gerrit.wikimedia.org/r/94909
Comment 3 Gerrit Notification Bot 2013-11-19 10:14:37 UTC
Change 96232 had a related patch set uploaded by Jens Ohlig:
(Bug 54324) Sequences in Lua should start with 1

https://gerrit.wikimedia.org/r/96232
Comment 4 Gerrit Notification Bot 2014-01-11 18:25:52 UTC
Change 96232 abandoned by Hoo man:
(Bug 54324) [DON'T MERGE] Sequences in Lua should start with 1

Reason:
Superseded by https://gerrit.wikimedia.org/r/106905 (which implements this behavior, but doesn't make it default)

https://gerrit.wikimedia.org/r/96232
Comment 5 Gerrit Notification Bot 2014-01-23 23:46:59 UTC
Change 107206 had a related patch set uploaded by Hoo man:
Introduce mw.wikibase.entity Lua library

https://gerrit.wikimedia.org/r/107206
Comment 6 Marius Hoch 2014-01-23 23:49:17 UTC
The listed patch will introduce a new mw.wikibase method which does that right, but leave the old legacy interface in place.
Comment 7 Gerrit Notification Bot 2014-02-07 11:55:43 UTC
Change 107206 merged by jenkins-bot:
Introduce mw.wikibase.entity Lua library

https://gerrit.wikimedia.org/r/107206
Comment 8 Marius Hoch 2014-02-07 12:26:01 UTC
Fixed for the new Lua interface, the legacy one will stay in place for now

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links