Last modified: 2013-09-25 17:47:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56339, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54339 - Add _rtselser end point in web api
Add _rtselser end point in web api
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
tests (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Marc Ordinas i Llopis
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-19 17:18 UTC by Gabriel Wicke
Modified: 2013-09-25 17:47 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-09-19 17:18:49 UTC
For end users and VE folks the non-selser _rt end point is often confusing, as it shows diffs that are normally avoided by selser. It would be useful to add a _rtselser end-point that serializes to HTML, re-parses that HTML (to catch foster-parenting issues) and then serializes it back with selser enabled.

This will provide us with a quick sanity check for the selser code, and a better link for end users and VE to establish that something has indeed dirtied the DOM.
Comment 1 ssastry 2013-09-19 17:22:14 UTC
Just for clarity, this will catch any unhandled fostered parenting issues in Parsoid. VE-DOM-dirtying will not be caught by this.
Comment 2 Roan Kattouw 2013-09-19 17:59:12 UTC
(In reply to comment #1)
> Just for clarity, this will catch any unhandled fostered parenting issues in
> Parsoid.
Depending on how it's written, it could catch these (or have a mode to detect these), by serializing the DOM out to a string and parsing it back in again.

With or without this kind of DOM normalization though, mass-testing articles to find selser bugs would be very awesome.

> VE-DOM-dirtying will not be caught by this.
Fortunately, VE does its own detection for this at run time: https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=visualeditor-needcheck
Comment 3 ssastry 2013-09-19 18:57:46 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Just for clarity, this will catch any unhandled fostered parenting issues in
> > Parsoid.
> Depending on how it's written, it could catch these (or have a mode to detect
> these), by serializing the DOM out to a string and parsing it back in again.

Yes, that is the intention. 

> With or without this kind of DOM normalization though, mass-testing articles
> to find selser bugs would be very awesome.

We haven't yet figured out how to do this reliably. We still have same problem that I mentioned on the VE/F page about absence of an oracle to tell us authoritative wikitext to compare against. So, the best we can do is simulate null edits, or modify text, etc. But those are, for the most part, the uninteresting bits of selser testing -- the most interesting bugs show up with more complex edits, and that is the bit that needs to be solved for using it in an automated manner in rt-testing.
Comment 4 Gerrit Notification Bot 2013-09-25 15:50:13 UTC
Change 85990 had a related patch set uploaded by Marcoil:
Bug 54339: Add _rtselser endpoint in web API

https://gerrit.wikimedia.org/r/85990
Comment 5 Gerrit Notification Bot 2013-09-25 17:47:19 UTC
Change 85990 merged by jenkins-bot:
Bug 54339: Add _rtselser endpoint in web API

https://gerrit.wikimedia.org/r/85990

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links