Last modified: 2013-09-27 18:00:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56378, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 54378 - OGG and OGV are listed twice as "Permitted file types" on Special:Upload


Summary:	OGG and OGV are listed twice as "Permitted file types" on Special:Upload

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Uploading (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	Low trivial (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-09-20 14:31 UTC by Sergey Leschina
Modified:	2013-09-27 18:00 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sergey Leschina 2013-09-20 14:31:32 UTC

Error is present in both Wikipedia and at Commons, e. g. https://en.wikipedia.org/wiki/Special:Upload

Comment 1 Andre Klapper 2013-09-20 15:59:13 UTC

Thanks for taking the time to report this! Confirming.

I wonder if that happens because once it refers to audio, and once to video.

$:andre\> grep -r "Permitted file types" .
./languages/messages/MessagesEn.php:
      'upload-permitted'            => 'Permitted file types: $1.',
$:andre\> grep -r "upload-permitted" .
./includes/specials/SpecialUpload.php:
  $this->msg( 'upload-permitted', $this->getContext()->getLanguage()->commaList( $wgFileExtensions ) )->parseAsBlock() .

Comment 2 Bawolff (Brian Wolff) 2013-09-20 16:24:22 UTC

Its because its added to $wgFileExtensions both in our LocalSettings, and in the setup code for TMH.

Solution would be to run array_unique on $wgFileExtensions before outputting it.

Comment 3 Gerrit Notification Bot 2013-09-25 19:54:15 UTC

Change 86021 had a related patch set uploaded by Brion VIBBER:
bug 54378: remove duplicate file extensions from output messages

https://gerrit.wikimedia.org/r/86021

Comment 4 Gerrit Notification Bot 2013-09-27 17:49:23 UTC

Change 86021 had a related patch set uploaded by Krinkle:
bug 54378: remove duplicate file extensions from output messages

https://gerrit.wikimedia.org/r/86021

Comment 5 Gerrit Notification Bot 2013-09-27 17:56:27 UTC

Change 86021 merged by jenkins-bot:
Remove duplicate file extensions from output messages

https://gerrit.wikimedia.org/r/86021

Comment 6 Brion Vibber 2013-09-27 18:00:47 UTC

Merged.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links