Last modified: 2013-09-25 23:18:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56422, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 54422 - TemplateData: Fix "PHP Notice: Trying to get property of non-object in TemplateDataBlob.php on line 385"


Summary:	TemplateData: Fix "PHP Notice: Trying to get property of non-object in Templa...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	TemplateData (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low trivial (vote)
Target Milestone:	---
Assigned To:	Krinkle

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-09-21 12:17 UTC by Bartosz Dziewoński
Modified:	2013-09-25 23:18 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2013-09-21 12:17:27 UTC

Notice: Trying to get property of non-object in …/extensions/TemplateData/TemplateDataBlob.php on line 385

$data->description->$langCode

"description" is not required to exist. Either it should be, or this line should check for it.

Comment 1 Krinkle 2013-09-25 16:47:17 UTC

It is normalised version and explicitly made optional. The save parser/validation and API reading handle it properly.

The html renderer forgets to check it.

Fixing..

Comment 2 Gerrit Notification Bot 2013-09-25 17:09:44 UTC

Change 86002 had a related patch set uploaded by Krinkle:
Account for absence of template description in #getHtml

https://gerrit.wikimedia.org/r/86002

Comment 3 Gerrit Notification Bot 2013-09-25 20:49:22 UTC

Change 86002 merged by jenkins-bot:
Account for absence of template description in #getHtml

https://gerrit.wikimedia.org/r/86002

Comment 4 Bartosz Dziewoński 2013-09-25 21:09:33 UTC

Thanks.

Comment 5 Gerrit Notification Bot 2013-09-25 22:45:54 UTC

Change 86045 had a related patch set uploaded by Krinkle:
Account for absence of template description in #getHtml

https://gerrit.wikimedia.org/r/86045

Comment 6 Gerrit Notification Bot 2013-09-25 22:46:07 UTC

Change 86046 had a related patch set uploaded by Krinkle:
Account for absence of template description in #getHtml

https://gerrit.wikimedia.org/r/86046

Comment 7 Gerrit Notification Bot 2013-09-25 22:47:44 UTC

Change 86046 abandoned by Krinkle:
Account for absence of template description in #getHtml

Reason:
Not worth backporting to wmf17 (fixes a hidden php notice and introduces a UI feature). We're rolling over to wmf18/wmf19 in less than < 20 hours.

https://gerrit.wikimedia.org/r/86046

Comment 8 Gerrit Notification Bot 2013-09-25 22:51:34 UTC

Change 86045 merged by jenkins-bot:
Account for absence of template description in #getHtml

https://gerrit.wikimedia.org/r/86045

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links