Last modified: 2014-10-02 17:50:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56439, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54439 - Paragraph split between a reference and italic text not noticed in --html2wt
Paragraph split between a reference and italic text not noticed in --html2wt
Status: RESOLVED WORKSFORME
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-21 20:19 UTC by Amir E. Aharoni
Modified: 2014-10-02 17:50 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Minimal test case for bug (typescript) (4.05 KB, application/octet-stream)
2013-09-25 03:06 UTC, James Forrester
Details

Description Amir E. Aharoni 2013-09-21 20:19:19 UTC
Of course, the title of the bug should probably be changed, because it's too local; I'm not sure how can I generalize it.

To reproduce:

1. Go to https://en.wikipedia.org/wiki/The_Well-Tempered_Clavier?veaction=edit . (I did it with revision https://en.wikipedia.org/w/index.php?title=The_Well-Tempered_Clavier&oldid=573956117 ).

2. Place the caret after footnote [2] and before the last sentence ("The Well-Tempered Clavier and Twenty-four Preludes and Fugues...").

3. Delete the space and press Enter to split the paragraph.

4. Press the save button and check the diff.

Observed: The message "Could not start the review because your revision matches the last version of the page."

Expected: To see a diff that would show a split paragraph.
Comment 1 James Forrester 2013-09-25 03:06:46 UTC
Created attachment 13371 [details]
Minimal test case for bug (typescript)
Comment 2 James Forrester 2013-09-25 03:07:48 UTC
Parsoid bug; retitled and Minimum test case attached.
Comment 3 Gabriel Wicke 2013-12-04 02:25:56 UTC
I don't see a split paragraph in your test case, the only change seems to be a newline inside the paragraph. If you'd like to add actual spacing you'd have to add a <br> instead.

Can you clarify why you think that this is a Parsoid issue?
Comment 4 ssastry 2014-10-02 17:50:18 UTC
I tested with the wt in the test case and the edit as shown there. This works on latest master.

[subbu@earth tests] node parse --selser --oldtextfile /tmp/wt --oldhtmlfile /tmp/old.html < /tmp/new.html
Foo.<ref>Bar</ref> 

''Baz''.

Bang.

<references />

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links