Last modified: 2013-09-24 19:00:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56446, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54446 - VisualEditor: Editor incorrectly selects slug and infobox onload
VisualEditor: Editor incorrectly selects slug and infobox onload
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-09-26
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-22 07:21 UTC by Krinkle
Modified: 2013-09-24 19:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (565.87 KB, image/png)
2013-09-22 07:21 UTC, Krinkle
Details
Screenshot of page after trying to Undo (302.70 KB, image/png)
2013-09-22 07:26 UTC, Krinkle
Details

Comment 1 Krinkle 2013-09-22 07:26:36 UTC
Created attachment 13347 [details]
Screenshot of page after trying to Undo

Causes loss of data as it makes it really easy to accidentally delete that selection when you start typing.

When you then try to do Undo, the following exception is thrown:

Uncaught Error: Cannot roll back a transaction that has not been committed 

Also, for some reason the font has become noticably smaller (only in the affected paragraph; see screenshot)
Comment 2 Ed Sanders 2013-09-24 15:32:53 UTC
This is cause by ve.ce.Surface#showSelection not being aware of the slug at the start of the document. Also, because the focusableNode logic takes places before showSelection is called, it tries to do a native selection.
Comment 3 Gerrit Notification Bot 2013-09-24 15:56:02 UTC
Change 85866 had a related patch set uploaded by Esanders:
Detect collapsed range inside focusable node in ve.ce.Surface#onChange

https://gerrit.wikimedia.org/r/85866
Comment 4 Gerrit Notification Bot 2013-09-24 17:21:45 UTC
Change 85866 merged by jenkins-bot:
Detect collapsed range inside focusable node in ve.ce.Surface#onChange

https://gerrit.wikimedia.org/r/85866

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links