Last modified: 2013-10-01 02:34:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56452, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54452 - A special page used as main page is displayed instead of any diff missing both title and curid parameters
A special page used as main page is displayed instead of any diff missing bot...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.22.0
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-22 17:41 UTC by Niklas Laxström
Modified: 2013-10-01 02:34 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2013-09-22 17:41:12 UTC 
1) Set mediawiki:mainpage to Special:SpecialPages
2) Follow rc link from irc output like https://dev.translatewiki.net/w/i.php?oldid=500706&rcid=832769 

Observed: special:specialpage loads
Expected: the diff
Comment 1 Niklas Laxström 2013-09-22 17:51:22 UTC 
Aaron, can you explain why you excluded special pages in commit 861f5a0f32f6b87063eb2c2f97b1706cf26f272a?
Comment 2 Niklas Laxström 2013-09-22 17:52:30 UTC 
I can workaround this in Wiki.php:

if ( is_null( $ret ) || !$ret->isSpecialPage() || $ret->equals( Title::newMainPage() ) {

But is there a better solution?
Comment 3 MZMcBride 2013-09-22 17:54:22 UTC 
(In reply to comment #1)
> Aaron, can you explain why you excluded special pages in commit
> 861f5a0f32f6b87063eb2c2f97b1706cf26f272a?

This link doesn't work and Aaron doesn't seem to be copied on this bug report.
Comment 4 Niklas Laxström 2013-09-22 18:06:39 UTC 
Of course it doesn't not work as it was not meant to be a link. Here is a link: https://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/23573

Aaron was not in CC because you edit conflicted with me in this bug.

Aaron: can you check the question above?
Comment 5 Nemo 2013-09-22 20:00:03 UTC 
Clarifying summary. Steps to reproduce:
1) Take any diff link, remove title and curid parameters if present
2) Open the link
Expected: if the diff and oldid IDs are not deleted, the diff is shown.
Actual: Special:MainPage is shown.
Comment 6 Nemo 2013-09-22 23:08:55 UTC 
> Steps to reproduce:

* Steps to reproduce on translatewiki.net
Comment 7 Niklas Laxström 2013-09-22 23:12:18 UTC 
Let's try again:

Step to reproduce:
1) Edit MediaWiki:MainPage in your wiki to say Special:SpecialPages
2) Go to Special:RecentChanges of your wiki and open any diff link
3) Remove curid and title parameters to match the links generated by RC UDP feed commonly relayed to IRC channels

Observed: Special:SpecialPages is shown
Expected: The diff is shown

Test this on your own wiki, not at (dev.)translatewiki.net!
Comment 8 Gerrit Notification Bot 2013-09-28 17:02:03 UTC 
Change 86381 had a related patch set uploaded by Nikerabbit:
Move 'main page as default title' further down to unbreak diff urls

https://gerrit.wikimedia.org/r/86381
Comment 9 Gerrit Notification Bot 2013-10-01 00:01:52 UTC 
Change 86381 merged by jenkins-bot:
Move 'main page as default title' further down to unbreak diff urls

https://gerrit.wikimedia.org/r/86381
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links