Last modified: 2014-11-18 21:20:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56522, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54522 - Images: Image responses could be cached to avoid identical API reqs (and also speed up parse)
Images: Image responses could be cached to avoid identical API reqs (and also...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
token-stream transforms (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-24 19:08 UTC by ssastry
Modified: 2014-11-18 21:20 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2013-09-24 19:08:06 UTC
Take a look at: http://parsoid.wmflabs.org:8001/perfstats?orderby=time:parse

Take a look at the first entry there: https://ja.wikipedia.org/w/index.php?title=%E6%9D%91%E6%AD%A3%E3%81%AE%E5%A6%96%E5%88%80&action=edit

On this page, check one of the transclusions and look at the expanded source on it as follows: "node parse --prefix ja --dump tplsrc < /tmp/wt_snippet" and you find this:

....
|[[ファイル:Go u.svg|20x20px]]
|[[ファイル:Go u.svg|20x20px]]
|[[ファイル:Go u.svg|20x20px]]
|[[ファイル:Go u.svg|20x20px]]
|[[ファイル:Go u.svg|20x20px]]
....

Now, Parsoid shoots off an API request for each image whereas this is unnecessary after the first response. This can significantly speed up the parse of this page.

The same is true for https://pl.wikipedia.org/wiki/Podsumowanie_start%C3%B3w_zespo%C5%82u_Lotus_w_Formule_1 which has a lot of identical image flags.

Caching could help here.
Comment 1 Gabriel Wicke 2013-12-04 00:32:42 UTC
Arlo, IIRC you worked in this area. Is this case already handled?
Comment 2 Arlo Breault 2013-12-04 00:41:14 UTC
It should be.

In 6e3c87504514201fc628c51977b3fd14a37667b0 we cached ImageInfoRequests.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links