Last modified: 2014-09-18 07:59:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56555, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54555 - Add force option to editTime
Add force option to editTime
Status: NEW
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Pywikipedia bugs
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-24 22:31 UTC by Kunal Mehta (Legoktm)
Modified: 2014-09-18 07:59 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2013-09-24 22:31:14 UTC
Originally from: http://sourceforge.net/p/pywikipediabot/patches/571/
Reported by: strainu
Created on: 2012-10-27 15:35:07
Subject: Force retrieval of last edit time
Original description:
This patch changes the Page.editTime function in order to allow the user to request a valid editTime even if the page has not yet been fetched. The API call used is theoretically much lighter than retrieving the whole page. The default behavior remains unchanged.
Comment 1 Kunal Mehta (Legoktm) 2013-09-24 22:31:16 UTC
forceEditTime.patch
Comment 2 Kunal Mehta (Legoktm) 2013-09-24 22:31:18 UTC
As a performance optimization, line 1256 could read

if force and not self.\_editTime:

However, I wrote the patch without checking if the editTime has been fetched because "force" should imply that the value is updated
Comment 3 Amir Ladsgroup 2014-07-24 08:06:17 UTC
The patch you made can be added to both core (in page.py) and compat (wikipedia.py) even though the patch is made for compat.

Sounds like a good idea
Comment 4 Strainu 2014-07-24 09:03:51 UTC
Hmm, I had forgot about this patch, despite the fact that I use it daily :)

Do you want me to put the patch up for review?
Comment 5 Amir Ladsgroup 2014-07-24 09:12:20 UTC
Yes, that would be awesome :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links