Last modified: 2014-08-13 16:55:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56576, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54576 - Parser tests fail en masse, falsely, when $wgUploadNavigationUrl is set differently
Parser tests fail en masse, falsely, when $wgUploadNavigationUrl is set diffe...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.22.0
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-24 23:18 UTC by Mark Holmquist
Modified: 2014-08-13 16:55 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark Holmquist 2013-09-24 23:18:42 UTC 
We should probably set $wgUploadNavigationUrl to the default value in the setup for the parser tests, and set it back on teardown (or maybe just leave it, I don't know how necessary the latter bit is)
Comment 1 Antoine "hashar" Musso (WMF) 2013-09-25 08:37:04 UTC 
That would happen whenever someone set $wgUploadNavigationUrl in their LocalSettings.php.  Most of the tests are assuming default values for our globals :/

tests/parser/parserTest.inc has setupGlobals() and  teardownGlobals() methods.
Comment 2 Gerrit Notification Bot 2014-08-08 19:44:28 UTC 
Change 152958 had a related patch set uploaded by Umherirrender:
Set $wgUploadNavigationUrl to false on parser and unit tests

https://gerrit.wikimedia.org/r/152958
Comment 3 Gerrit Notification Bot 2014-08-13 15:12:59 UTC 
Change 152958 merged by jenkins-bot:
Set $wgUploadNavigationUrl to false on parser and unit tests

https://gerrit.wikimedia.org/r/152958
Comment 4 Umherirrender 2014-08-13 16:55:38 UTC 
successfully merged
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links