Last modified: 2014-02-28 23:41:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56587, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54587 - VisualEditor: Inserting a reference breaks up annotations around it
VisualEditor: Inserting a reference breaks up annotations around it
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-25 02:04 UTC by Roan Kattouw
Modified: 2014-02-28 23:41 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-09-25 02:04:02 UTC 
When you insert a reference in the middle of a bolded word, the reference itself doesn't receive a bold annotation, and so the resulting text is something like '''He'''<ref name="hello" />'''llo''', with the bold breaking around the reference.

When we insert inline nodes like references from the UI, they should take annotations. This is probably a wider problem beyond just references.
Comment 1 Ed Sanders 2013-09-27 11:06:18 UTC 
The dialogs generate insertion transactions directly with newFromInsertion, and have no insertion annotation logic.
Comment 2 Ed Sanders 2013-09-29 16:40:40 UTC 
Also, I'm not sure this is desirable behaviour.
Comment 3 James Forrester 2013-10-02 23:14:54 UTC 
(In reply to comment #2)
> Also, I'm not sure this is desirable behaviour.

But we are. :-)
Comment 4 Ed Sanders 2013-10-24 14:51:16 UTC 
See bug 48720.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links